Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don’t release Large Type windows on close #2521

Merged
merged 2 commits into from Jun 25, 2020
Merged

don’t release Large Type windows on close #2521

merged 2 commits into from Jun 25, 2020

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented May 26, 2020

This prevents the app from crashing when dismissing the Large Type interface. I have a VM running Catalina, so I was able to test there too.

@skurfer
Copy link
Member Author

skurfer commented May 26, 2020

Oh, I also threw in a small casting fix I've had uncommitted locally forever.

@skurfer
Copy link
Member Author

skurfer commented May 26, 2020

Even better, I removed the array altogether. Everything still seems to work.

@skurfer skurfer merged commit 57a11e4 into master Jun 25, 2020
skurfer added a commit that referenced this pull request Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant