Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Quicksilver.icns 2022 #2595

Merged
merged 2 commits into from
Feb 12, 2022
Merged

Update Quicksilver.icns 2022 #2595

merged 2 commits into from
Feb 12, 2022

Conversation

vadimrob
Copy link
Contributor

@vadimrob vadimrob commented Feb 3, 2022

new quicksilver icon 2022
what do you think?

qs
Screenshot 2022-02-03 at 12 18 48
2

new quicksilver icon 2022
@pjrobertson
Copy link
Member

That was quick, great job @vadimrob ! It looks like you've switched back to the purple background / white foreground of the current icon, as opposed to the inverted colours of your original icon?

quicksilver 2x

Are you able to make one with inverted colours? Then we can compare the two and have a vote, to choose which is the preferred icon! I'm thinking something like this icon in your dock pic:
152326188-9cd9285b-f6b2-4645-b195-e594db3d6e96

Also, here's how the icon looks in the 'Quit Quicksilver' dialog. If you could post that for the inverted colours, that would be helpful.

Screenshot 2022-02-04 at 08 24 16

@vadimrob
Copy link
Contributor Author

vadimrob commented Feb 4, 2022

@pjrobertson Yes it was quick you caught me in a less busy moment of the day and I quickly whiped something up. Yes I reverted back to the origins and gave the overall icon more of the QS color, but a little modified a little punchier a combination of Electric Violet and Eminence color. I think it gives more impact and visual identity impact in the dock, because so few apps have that background color.

But I will do the inverted version also just give me a few days to complete it to find some time.

Thanks!

Oh and btw, the S icon in the dock is https://outercorner.com/secrets-mac/ for anyone interested :)

@pjrobertson
Copy link
Member

pjrobertson commented Feb 5, 2022 via email

@skurfer
Copy link
Member

skurfer commented Feb 5, 2022

There’s already a “squircle” icon on the master branch. See if it’s suitable before doing too much work here.

@pjrobertson
Copy link
Member

Thanks for the heads up @skurfer - I wasn't aware of that updated one here

I'd vote for continuing with @vadimrob's icon, as he's also given it a more modern feel. Just waiting to see the inverted colours then we can decide which one to go for.

@vadimrob
Copy link
Contributor Author

vadimrob commented Feb 7, 2022

Attached is the inverted version:
152451644-bf4128c0-5fe7-47e4-b196-9502679ca397 2
qsw

@pjrobertson
Copy link
Member

Great, thanks! I think I like the normal one more. @vadimrob - what are your thoughts?

Let's have a vote!

React to this message with:

  1. A rocket 🚀 for the purple background with white logo
  2. A hooray 🎉 for the white background with purple logo

@vadimrob
Copy link
Contributor Author

vadimrob commented Feb 8, 2022

I will abstain from voting! :D I just create them you guys vote and decide.

Great, thanks! I think I like the normal one more. @vadimrob - what are your thoughts?

Let's have a vote!

React to this message with:

  1. A rocket 🚀 for the purple background with white logo
  2. A hooray 🎉 for the white background with purple logo

I will abstain from voting! :D I just create them you guys vote and decide!

@pjrobertson
Copy link
Member

pjrobertson commented Feb 10, 2022

Looks like the rocket has it so far! Voting will close in 12 hours, at 12:00pm (UTC). :D

@pjrobertson pjrobertson added this to the 1.7.0 milestone Feb 10, 2022
@pjrobertson
Copy link
Member

Votes are in, we're going with purple backround + white logo!

@vadimrob - can you also update the Quicksilver@2x.icns file in the same folder and re-push here.

Then we'll get it merged.

Thanks!

@vadimrob
Copy link
Contributor Author

@pjrobertson Hello! I'm a little busy with selling my car Today, but I'll update the required files Tomorrow.

@pjrobertson
Copy link
Member

👍 good luck selling your car!

@vadimrob
Copy link
Contributor Author

Thank you! I sold it thankfully without problems.

@pjrobertson
Copy link
Member

This looks great, thanks once again! Congratulations on your first commit to Quicksilver, and also on selling the car 😄

Looking forward to getting this into the next release.

If you feel up for it, many of Quicksilver's other icons in this folder could do with a touch up. But that's probably quite a challenge, and may take up a fair amount of time.

@pjrobertson pjrobertson merged commit 5869a80 into quicksilver:master Feb 12, 2022
@vadimrob
Copy link
Contributor Author

Thank you! Glad I could contribute. I don't know about the rest of the graphics, kinda low on time these days, but when I have time and feel like it I surely could help :).

pjrobertson added a commit that referenced this pull request Feb 13, 2022
@lgarron
Copy link
Contributor

lgarron commented Mar 17, 2022

Would it make sense to add more resolutions to the .icns files?

In #2544 I put a lot of care into the dimensions to match Apple's guidelines/icons, and also to make sure that the horizontal short line at the bottom remains visible in Finder at 1x monitor resolution (right side of screenshot).

Screen Shot 2022-03-16 at 17 41 39

@pjrobertson
Copy link
Member

You raise a good point, Lucas. I've noticed the icons look 'fuzzy' when really small:
Screenshot 2022-03-17 at 09 36 41

I wasn't quite sure how to go about fixing these. Would you be able to add in the missing icon sizes? I'm not sure if that's possible since you don't have the original file from @vadimrob - or maybe you can remake them using the same colour theme?

Thanks!

@vadimrob
Copy link
Contributor Author

quicksilverxrt.afdesign.zip
Hello, here is the Affinity Design editable file. Sadly I don't have the time to do further work for now.

Thanks!

@pjrobertson
Copy link
Member

Thanks for this @vadimrob - much appreciated, and stay safe.

lgarron added a commit to lgarron/Quicksilver that referenced this pull request Mar 26, 2022
This is an adaptation of the design from quicksilver#2595 with some of the tweaks from quicksilver#2544 to make the icon look sharper at small resolutions. In particular, the 16x16 icon contains a lot of manual adjustments.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants