New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
More localization #260
More localization #260
Conversation
Now it really always returns something.
…to [NSBundle_BLTRExtensions safeLocalizedStringForKey] to reduce code duplication. distributedLocalizedStringForKey will be removed in the future. As will the whole QSLocalization class (I think).
Added/moved redefinitions of NSLocalizedString Macros to use safeLocalizedStringForKey.
Testing this now. |
Probably just the localisation of some plugins. But it is, for example breaking my 1Password action names. They're showing up as the actual method names 'goAndFill' instead of 'Go & Fill' |
Ok, I'll have another look at it. Seems to be even more complicated than I thought :-/ |
… an empty string. Users of this method have to make sure to set a default value if they need it.
I guess I was a little overzealous when providing fallback options for when a localization attempt failed. Should work better now. |
Seems good. I see you've just used no localisation for 'Type to Search' - is it a tough one to localise? Haven't found any problems with this one, testing in various languages (French, English, Greek -> defaulting to German) and it's all good. Maybe we should make a wiki where people can contribute to the localisations? I'll use this pull as my running QS for a bit just incase there are any oddities ;) |
No, I didn't localize "Type to Search", because I actually didn't
Wait, it's defaulting to German? It should default to English.
Yeah...that's a major undertaking. :-/ |
It's defaulting to the next language in the list in 'Language and Text' in On 3 May 2011 22:29, HenningJ <
|
Seems sweet. |
More localization & fixes issue #250
Ouvrir should be spelled Ouvier in the French localization. |
except it's in reverse ;) Apparently it's only misspelled in the triggers prefpane. |
Can you guys open a new support ticket for this? :) Where exactly is the typo? Thanks! |
done |
Ok, different localization stuff. :-)
This fixes issue #250.
Also, there were two functions that handled localization stuff. I refactored them into one.
NSBundle (BLTRExtensions) now handles the localization stuff. QSLocalization is still there, because there is still some weirdness going on. But less than before. :-)