Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More localization #260

Merged
merged 6 commits into from May 4, 2011
Merged

Conversation

HenningJ
Copy link
Contributor

Ok, different localization stuff. :-)
This fixes issue #250.

Also, there were two functions that handled localization stuff. I refactored them into one.
NSBundle (BLTRExtensions) now handles the localization stuff. QSLocalization is still there, because there is still some weirdness going on. But less than before. :-)

…to [NSBundle_BLTRExtensions safeLocalizedStringForKey] to reduce code duplication.

distributedLocalizedStringForKey will be removed in the future. As will the whole QSLocalization class (I think).
Added/moved redefinitions of NSLocalizedString Macros to use safeLocalizedStringForKey.
@pjrobertson
Copy link
Member

Testing this now.

@pjrobertson
Copy link
Member

  1. Problems with action names. They're just showing up as e.g. 'QSLoginItemAddAction'. In the command window and Triggers pref pane, actions pref pane etc. etc.

Probably just the localisation of some plugins.

But it is, for example breaking my 1Password action names. They're showing up as the actual method names 'goAndFill' instead of 'Go & Fill'

@HenningJ
Copy link
Contributor Author

Ok, I'll have another look at it. Seems to be even more complicated than I thought :-/

… an empty string. Users of this method have to make sure to set a default value if they need it.
@HenningJ
Copy link
Contributor Author

HenningJ commented May 1, 2011

I guess I was a little overzealous when providing fallback options for when a localization attempt failed. Should work better now.

@pjrobertson
Copy link
Member

Seems good. I see you've just used no localisation for 'Type to Search' - is it a tough one to localise?

Haven't found any problems with this one, testing in various languages (French, English, Greek -> defaulting to German) and it's all good.
Except half the actions still aren't translated. We need to get working on that :/

Maybe we should make a wiki where people can contribute to the localisations?

I'll use this pull as my running QS for a bit just incase there are any oddities ;)

@HenningJ
Copy link
Contributor Author

HenningJ commented May 3, 2011

Seems good. I see you've just used no localisation for 'Type to Search' - is it a tough one to localise?

No, I didn't localize "Type to Search", because I actually didn't
localize anything. I just tried to fix parts of how localization is
handled.
But now that I think about it, I don't really know how to say that in German.

Haven't found any problems with this one, testing in various languages (French, English, Greek -> defaulting to German) and it's all good.

Wait, it's defaulting to German? It should default to English.

Except half the actions still aren't translated. We need to get working on that :/
Maybe we should make a wiki where people can contribute to the localisations?

Yeah...that's a major undertaking. :-/

@pjrobertson
Copy link
Member

Haven't found any problems with this one, testing in various languages (French, English, Greek ->
defaulting to German) and it's all good.

Wait, it's defaulting to German? It should default to Englis

It's defaulting to the next language in the list in 'Language and Text' in
the prefs. I'd set it to Greek -> German -> British English
so I'd say it was doing the right thing in localising to German (since it
was next in my list)
I tried with Greek -> French and it was defaulting to French. This is how
OS X works if I remember correctly, so I don't see any problems with what
you've done :)

On 3 May 2011 22:29, HenningJ <
reply@reply.github.com>wrote:

Seems good. I see you've just used no localisation for 'Type to Search' -
is it a tough one to localise?

No, I didn't localize "Type to Search", because I actually didn't
localize anything. I just tried to fix parts of how localization is
handled.
But now that I think about it, I don't really know how to say that in
German.

Haven't found any problems with this one, testing in various languages
(French, English, Greek -> defaulting to German) and it's all good.

Wait, it's defaulting to German? It should default to English.

Except half the actions still aren't translated. We need to get working
on that :/
Maybe we should make a wiki where people can contribute to the
localisations?

Yeah...that's a major undertaking. :-/

Reply to this email directly or view it on GitHub:
#260 (comment)

@pjrobertson
Copy link
Member

Seems sweet.
It's nice to have the 'type to search' text back. Makes QS that bit easier to understand... :)

pjrobertson added a commit that referenced this pull request May 4, 2011
@pjrobertson pjrobertson merged commit cf7f329 into quicksilver:master May 4, 2011
@philostein
Copy link
Contributor

Ouvrir should be spelled Ouvier in the French localization.

@jeanravin
Copy link

except it's in reverse ;) Apparently it's only misspelled in the triggers prefpane.

@pjrobertson
Copy link
Member

Can you guys open a new support ticket for this? :)

Where exactly is the typo?

Thanks!

@jeanravin
Copy link

done
#554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants