Fix for #460 #2605
Merged
Fix for #460 #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjrobertson
force-pushed
the
fix-460
branch
2 times, most recently
from
e7f08eb
to
83d67e5
Compare
…oading plugins Previously, the last plugin to create QSApplicationActions for a certain app's action would overwrite any existing actions. This change adds the any new actions to the existing ones, instead of blindly over-writing Fixes #460
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another very simple one. Add new actions to the existing dict, instead of replacing the dict entirely.
Right now, the last plugin to load QSApplicationActions for a certain app's bundle ID would chomp and overwrite any existing dictionary that was already loaded.
This change makes a Mutable dict for QSApplicationActions, and adds any new actions to the existing list, instead of blindly over-writing
Fixes #460