Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable 'watch folder' for custom catalog entries #2633

Merged
merged 1 commit into from
Feb 17, 2022
Merged

Conversation

pjrobertson
Copy link
Member

Fixes #330

I forgot how much of a mess QSLibrarian/QSCatalogEntry actually is :/ This works, but to implement it 'nicely' would require completely rewriting QSLibrarian. Not happening any time soon.

Added new option to sidebar for files & folder catalog type:
Screenshot 2022-02-13 at 14 12 20

To test:

  1. Create a new folder catalog entry (e.g. for 'Desktop')
  2. Enable the "Automatically update when files change" option
  3. Keep your Quicksilver catalog prefs open so you can see the 'count' badge next to your new entry from 1.
  4. Create a new file in the folder from 1 (e.g. 'Desktop')
  5. Confirm number goes up/down
watch.mov

@pjrobertson
Copy link
Member Author

I'm thinking about this in hindsight: computers are way more powerful now. Should we just do away with the manual rescan for file object sources, and just make all of them update automatically? Or is that asking too much, if someone accidentally adds a folder with a gazillion sub-folders?

@n8henrie
Copy link
Member

n8henrie commented Feb 13, 2022 via email

@pjrobertson pjrobertson changed the title Allow user to automatically folders of custom catalog entries Enable 'watch folder' for custom catalog entries Feb 16, 2022
@skurfer
Copy link
Member

skurfer commented Feb 16, 2022

Should we just do away with the manual rescan for file object sources, and just make all of them update automatically?

The last time someone asked about that, I heard there were limits in the OS for how many files a process was allowed to watch, but I don’t know if that’s still true or what the limit might be.

@pjrobertson
Copy link
Member Author

If this works, I say let's merge it for now. Automatically update all files/folders can come in another update, down the line ;-)

@skurfer skurfer merged commit 0b04943 into master Feb 17, 2022
@skurfer skurfer deleted the watch-entries branch February 17, 2022 13:29
skurfer added a commit that referenced this pull request Feb 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Watch directories for modification
3 participants