Remove QSBackgroundView #2635
Merged
Remove QSBackgroundView #2635
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjrobertson
force-pushed
the
qsbackgroundview
branch
from
afebde6 to
a0a811c
Compare
|
The contrast isn’t ideal depending on the chosen colors, but it’s still a big improvement. |
Agreed. I'll take a look at tweaking the Default QS colours. It may make sense to spruce up QS's colour palette based on the new logo anyway. |
|
@skurfer - if you're updating the CHANGELOG - make sure to EDIT: You're one step ahead. Already done it I see ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the same light as removing QSGlossyBar, this removes QSBackground view, and its custom 'fancy' drawing.
Edit: removing the view was a bit premature, it is actually used by a couple of plugins. Instead, I just removed the code draws the gradient backgrounds.
It makes the Results Window more 'flat' and hopefully more 'modern':
I also properly bound the results view header/footer text colour to the appearance prefs, fixing #1235
I'm a little bit more confident that these changes may help with the Catalina/Big Sur colour problems. Less archaic code is good, right?! :D