Fix colours for dark mode

[pjrobertson]

Removes previous 'custom' colours (yellow/purple etc.) from Triggers/Catalog/Plugins views, but by not hard-coding colours, we can use the system's defaults

Fixes #2638

[pjrobertson]

Some screenshots (could still be improved, but this is much better than before).

[n8henrie]

Looks great here too, thanks for sorting this out!

#2537 (comment)

[pjrobertson]

@n8henrie @skurfer - there's one more view that I can't update. Xcode keeps crashing on me. I'm only on Xcode 11, maybe it was fixed in a later Xcode. Can you try the following:

1. Open up the QSHelpersPrefPane.xib file
2. Accept the warning:
   
3. Click on the table, then in the sidebar drill down until you get to the 'table view' item (see left of pic below)
4. After clicking the table, go to the right sidebar and change 'Grid Color' to 'Separator Color'
5. Save, commit, then push back here.

Every time I hit save, Xcode crashes :(

[skurfer]

there's one more view that I can't update. Xcode keeps crashing on me.

That’s been happening since Xcode 8. I upgraded all the NIBs at one point, but had to skip that one. I even tried using the command-line ibtool on it, but no luck.

We talked about it in #2295. This other comment makes it sound like I fixed it somehow, but obviously, I didn’t.

[pjrobertson]

OK, if that's the case I'll follow the instructions here

The crash log for Xcode gives some explanation:

ASSERTION FAILURE in /Library/Caches/com.apple.xbs/Sources/IDEInterfaceBuilder/IDEInterfaceBuilder-15505/InterfaceBuilderKit/Document/IBDocument.m:2557
Details:  An instance of NSWindowTemplate with object ID 5 did not archive its child (NSPopUpButtonCell) with an object of ID 144.
Edit log: (
    "Change Grid Color"
)

[pjrobertson]

@skurfer - I did see one mention that it was an issue with Mojave. If possible, can you please try opening and saving on your latest Xcode/macOs, just in case. If it's still no-go I'll follow the steps above

[skurfer]

Opening and saving in Xcode 13.2 on macOS 12.2.1 → Instant crash

[pjrobertson]

👍 for checking, thanks. 👎 for Xcode! I'll look into it.

[n8henrie]

My saga with the insta-crash on QSHelpersPrefPane.xib (and a few posts below): #2537 (comment)

I couldn't get it figured out. Tried looking at the diffs made with the Xcode "auto-fix" on similar files to see if I could do it manually, but it didn't seem practical.

[skurfer]

Wait, just like I said in the linked comment, removing the two button cells at the bottom allows me to save it. Do they do anything? Trying to test now.

[pjrobertson]

Rob to the rescue! That's it, great catch. Those NSPopupCells were just 'floating' which probably isn't allowed and hence why Xcode was crashing.

I was able to open and delete them as well. Xib updated and pushed here. This PR should be good to go now.