Performance tweaks #2644
Merged
Performance tweaks #2644
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Means it's only made once, saving a tiny bit on memory/performance
…ocalKey Previously, NSURLVolumeURLKey was being called, then NSURLVolumeIsLocalKey was being called on that value. We can just ask NSURLVolumeIsLocalKey on the file itself.
Nice performance boost
This was a huge bottleneck, mainly when presenting actions. Previously, actions were being compared to every other object in the catalog using the `[data isEqualToDictionary:anObject->data]` - very wasteful. Instead, if the classes aren't the same (e.g. QSObject vs. QSAction) then we know straight away that the objects aren't the same
As opposed to deprecated activeApplication
Closed
Improves performance, and fixes #2356
|
From one ten-year-old-Mac owner to another, cheers to you, good sir. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It helps having a 10 year old Mac ;-) I wouldn't say QS is 'slow', but it could definitely be snappier.
These changes are based on profiling using Instruments. Overall searching should be slightly faster, displaying action should be faster.
I propose this isn't merged into 2.0.0, but saved for a later release. We've got enough to work on right now.