Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 'Get Current Selection' service menu #2651

Closed
wants to merge 3 commits into from
Closed

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 21, 2022

This fixes the hotkey to ⌘⎋ and fixes #2646

I've also added another change here to rename the service to "Send to Quicksilver" as per #2119

I send to agree that 'get current selection' is not that descriptive. I also decided to remove the (Do not change) part: it is ugly, and in the small edge case that users change it, they'll find that it breaks and likely just click the 'restore defaults' button in the menu any.

Still, the fact you cannot change the hotkey, and how to fix it if you do (click 'Restore Defaults') should be documented in the manual.

I also made one more change, to reduce the timeout of the service from 10s to 5s. 10s really is too long in this day and age

@pjrobertson pjrobertson added this to the 2.0.0 milestone Feb 21, 2022
@pjrobertson
Copy link
Member Author

Oops, I accidentally just pushed these changes to master. This PR is more to discuss and confirm that we're ok with renaming the service to 'Send to Quicksilver'

@n8henrie
Copy link
Member

n8henrie commented Feb 21, 2022 via email

@skurfer
Copy link
Member

skurfer commented Feb 22, 2022

Looks good. So should we just close this?

@skurfer skurfer closed this Feb 22, 2022
@skurfer skurfer deleted the fixServiceKey branch February 22, 2022 16:00
skurfer added a commit that referenced this pull request Feb 22, 2022
@pjrobertson
Copy link
Member Author

There was one more commit I didn't push to master (this one 5b6b2e0) so I've done that now

@skurfer
Copy link
Member

skurfer commented Feb 23, 2022

I’m seeing a similar problem with the Command Window with Selection trigger. That one uses a key code and has the correct value, but it appears as ⌘5. And it’s not truncating from 53. I discovered this because ⌘5 was invoking QS. I’m not sure what the fix is, but I also don’t remember why we even need that trigger. I disabled it and ⌘⎋ still works as expected in every app.

@pjrobertson
Copy link
Member Author

Hmm.... I do see a problem with setting a trigger that uses ⎋.

E.g. if I set a trigger to ⌥⎋ it appears as ⌥5 and reacts to ⌥5.

RE the 'Command Window with Selection', I found this in the Changelog for v1.0.0 (9 years ago!)

Simplify Services and set the "Command Window with Selection" trigger to use ⌘⎋ by default (#409, #1295, #1416, #1418)

I will create a new issue for this and look into it

@pjrobertson
Copy link
Member Author

@skurfer - please try the latest master to see if that fixes the 'Command Window with Trigger' issue.

Oh, and to answer this:

but I also don’t remember why we even need that trigger

You can see your own comment here, hehehe ;-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Get Current Selection Service no longer works
3 participants