Update Primer interface for dark mode #2697
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Do we need any changes related to NDHotKey in this PR? I’d say remove those so the conflict goes away, then feel free to merge (or I will). |
Don't let users set the Primer interface colour
pjrobertson
force-pushed
the
primerDarkMode
branch
from
2be0448
to
cfe4d59
Compare
|
Sorry, not sure what happened there. Have just re-pushed. Once the build checks are successful I'll merge :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2695
Note that this is also explicitly disables using custom colours for the Primer interface. It was already pretty messy before: you could only change the window background colour, and that was done by setting the "Result Headers" background colour. Strange.
I figured since Primer is a... 'primer' interface, then hard-coding colours is preferable.