Fixed handling of CapsLock as double modifier activation sequence. #2717
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
LGTM, thanks dhopefl! |
|
I have also added your name to the Credits in Quicksilver, and it will now appear in the Quicksilver about window. |
|
Thanks a lot, I am honored. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As mentioned in #2706, CapsLock as trigger did not work.
This PR fixes it, but due to the slow keys accessibility feature, using it requires good timing. I did not find an API call to query if slow keys is active for CapsLock (or the slow keys delay). Users that want to use double-CapsLock to trigger QS should probably turn of slow keys.