Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename #328

Merged
merged 4 commits into from May 24, 2011
Merged

Rename #328

merged 4 commits into from May 24, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 22, 2011

Made the 3rd pane only select the file's name (no the extension) when using the 'rename' action.
Same as Finder's behaviour.

@pjrobertson
Copy link
Member Author

pjrobertson commented May 22, 2011

Sorry, seems to be a bit messy this pull. I've got too many pull requests at the moment :/

@skurfer
Copy link
Member

skurfer commented May 22, 2011

This has been annoying me too. I haven’t actually tried this, but just looking at the code, wouldn’t this fail to work as expected on files with more than one .? Like my.new.file.zip would only have “my” selected, right?

Maybe instead of splitting on ., just do

NSString *fileName = [defaultValue stringByDeletingPathExtension];

and let Apple do the work of figuring out what that means. :)

@pjrobertson
Copy link
Member Author

pjrobertson commented May 22, 2011

Yeah that's a better idea. I'll do that, test it out, then add another
commit

On 22 May 2011 23:03, skurfer <
reply@reply.github.com>wrote:

This has been annoying me too. I havent actually tried this, but just
looking at the code, wouldnt this fail to work as expected on files with
more than one .? Like my.new.file.zip would only have my selected,
right?

Maybe instead of splitting on ., just do

NSString *fileName = [defaultValue stringByDeletingPathExtension];

and let Apple do the work of figuring out what that means. :)

Reply to this email directly or view it on GitHub:
#328 (comment)

@pjrobertson
Copy link
Member Author

pjrobertson commented May 22, 2011

See what you think of this now.

I've also added a check to make sure that QS still selects all the text in the 3rd pane if you're not using the rename action:

  1. stick 'help.me' in a find field in OS X somewhere - e.g. XCode's,
  2. invoke 'some search URL' ⇥ 'Search For' ⇥
  3. help.me should show in the 3rd pane. With this fix, all of it should be selected.

@skurfer
Copy link
Member

skurfer commented May 23, 2011

Tired it. Love it. Want to merge it… but that QSLibrarian stuff is in there which I need to look at more closely.

stick 'help.me' in a find field in OS X somewhere

Or just select it and hit ⌘E. :)

@pjrobertson
Copy link
Member Author

pjrobertson commented May 23, 2011

oooh CMD + E - didn't know that :)

Yeah the pull's really messy, hopefully the other pull's fine and you can
just merge this one :)

On 23 May 2011 11:41, skurfer <
reply@reply.github.com>wrote:

Tired it. Love it. Want to merge it… but that QSLibrarian stuff is in there
which I need to look at more closely.

stick 'help.me' in a find field in OS X somewhere

Or just select it and hit ⌘E. :)

Reply to this email directly or view it on GitHub:
#328 (comment)

@skurfer
Copy link
Member

skurfer commented May 24, 2011

The QSLibrarian stuff looks correct (I let the debugger step through it a few times) so… merge.

skurfer added a commit that referenced this pull request May 24, 2011
@skurfer skurfer merged commit aed3841 into quicksilver:master May 24, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants