created a new method that returns the full OS X version, updated all HTTP #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…HTTP requests to use a new User Agent
|
Sorry, didn't realise that =/ |
|
So, what was the consensus here? Merge? I like it. :-) |
|
I think it should be merged :) It means I can do all sorts of fancy things to sniff out what are users are using on QSApp.com. :) |
|
Yay. :-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
created a new method that returns the full OS X version, updated all HTTP requests to use a new User Agent
The new user agent is of the format:
Quicksilver Quicksilver Build Number (Mac OS X OS Version Number in Format 10.x.x)
@ddl_smurf - since this will likely be used by the plugins PHP script, can you let me know if this format is acceptable for the User Agent (I'm sure there's something better).
Basically - whatever would be easiest to sniff in a PHP script when QS is asking for the plugins list.