Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improved latest download proxy for SL - always returns right file #377

Merged
merged 2 commits into from Jun 14, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 13, 2011

It was annoying me that the fileModificationDate method doesn't always return the right date we want — i.e. when the file was saved to your computer, so I've written some SL specific code that uses NSURLs and the NSURLAttributeModificationDateKey which works consistently.

On a side note, I've used [NSFileManager alloc] init] instead of [NSFileManager defaultManager] as the docs specify:

In Mac OS X v 10.5 and later you should consider using [[NSFileManager alloc] init] rather than the singleton method defaultManager. Using [[NSFileManager alloc] init] instead, the resulting NSFileManager instance is thread safe.

Also feels snappier for me :)

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 14, 2011

It was annoying me that the fileModificationDate method doesn't always return the right date we want

Same here. I’m glad you found a way around it. (Although I thought you said you didn’t see this problem.)

skurfer added a commit that referenced this issue Jun 14, 2011
improved latest download proxy for SL - always returns right file
@skurfer skurfer merged commit 0425756 into quicksilver:master Jun 14, 2011
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 14, 2011

I didn't, but then I did! I guess it all depends on the file you were downloading :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants