Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allowed QS to browse PHP URLs that end in ?key=value&anotherKey=AnotherVa #379

Merged
merged 1 commit into from Jun 16, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 14, 2011

Allowed QS to browse PHP URLs that end in ?key=value&anotherKey=AnotherValue

Simple really. Just get the 1st part of the string separated by ? — this'll be the domain and path

I can't think of any cases where a ? would come before the path, so I don't think this can be broken

e.g. try this in QS:
http://qsapp.com/plugins/?order=name&sort=DESC

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 14, 2011

I notice that the plug-ins page only shows 8 children. It seems to stop when it gets to “ß60 ONLY”. The parser doesn’t have any problem with it, so it must be something with NSTask and how it reads the results. I tried setting a bunch of encoding-related environment variables for task, but it made no difference.

You’re changes seem fine though. :)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 14, 2011

Just off the top of my head, it's probably something to do with UTF-8
encoding...

On 15 June 2011 01:31, skurfer <
reply@reply.github.com>wrote:

I notice that the plug-ins page only shows 8 children. It seems to stop
when it gets to 60 ONLY. The parser doesnt have any problem with it, so
it must be something with NSTask and how it reads the results. I tried
setting a bunch of encoding-related environment variables for task, but it
made no difference.

Youre changes seem fine though. :)

Reply to this email directly or view it on GitHub:
#379 (comment)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 16, 2011

The plugins page works fine for me in QS. Any problems with merging this?

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 16, 2011

So it does. It seems to be a problem with the new (not yet merged) HTML parser. I’ll have to see what’s different about the output.

skurfer added a commit that referenced this issue Jun 16, 2011
Allowed QS to browse PHP URLs that end in ?key=value&anotherKey=AnotherVa
@skurfer skurfer merged commit a3f7afa into quicksilver:master Jun 16, 2011
@skurfer
Copy link
Member

@skurfer skurfer commented Jun 16, 2011

OK, the new parser handles the plugins page correctly now. I had done most of the UTF-8 work, but forgot to change one line.

@philostein
Copy link
Contributor

@philostein philostein commented Aug 18, 2011

This may be the wrong place, but browsing the wiki through QS fails when showing the contents of URL:
http://QSApp.com/wiki/Where_is_everything?

The wiki wants http://QSApp.com/wiki/Where_is_everything%3F but QS uses the '?' and hits the 'no text' page.

@skurfer
Copy link
Member

@skurfer skurfer commented Aug 18, 2011

The underlying parser seems to be returning the correct info:

/wiki/Where_is_everything%3F    Where is everything?        

So Quicksilver must be doing something “smart” with it after that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants