Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added new QS icons and DMG icons #383

Merged
merged 1 commit into from Jun 22, 2011
Merged

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 16, 2011

Thanks to Dan Deming-Henes for these. He's also the guy who's done the new QSApp.com redesign so we've got a lot to thank him for!

I think the new icon looks great in the dock - makes QS feel like it's been dusted over a bit to get rid of the cobwebs :)

We'll be using the .dmg icon for all future releases unless anyone has any objections.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 16, 2011

Anybody wanting to see the difference can do so here (I actually had the old image lying around, so it was easy to make the new one :)

http://i.imgur.com/nkPRO.png

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Jun 17, 2011

hmmm...seeing it side by side like that, I think it should be a little darker. On it's own, I didn't even notice ;-)

@haxrat
Copy link

@haxrat haxrat commented Jun 17, 2011

i think new icon should have gloss

@burningTyger
Copy link

@burningTyger burningTyger commented Jun 17, 2011

no gloss please. That is so Web 2.0 :)

@philostein
Copy link
Contributor

@philostein philostein commented Jun 17, 2011

I like it a lot. Sharper lines and shadows, and a subtle gradient. The colour is quite a bit brighter, but at least it's obvious what it's supposed to be. Thightower thought it was supposed to be grey, it was that dark.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 20, 2011

Does anyone else think we it should be darkened a bit?
It's true that it is lighter than the previous icon, but I don't think that's necessarily a bad thing. I prefer it :)

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 20, 2011

Are there little tweaks we could make? Yes. (For instance, I wonder if the white border should be removed at smaller sizes.) Is it a good icon as is? Yes.

When was design-by-committee ever a good idea? :)

I’m fine with merging it, but I’ll wait a day or so for objections.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 22, 2011

It's been a day or so... :)

Dan's said he's happy to work on brushing up the prefs icons as well :D

skurfer added a commit that referenced this issue Jun 22, 2011
added new QS icons and DMG icons
@skurfer skurfer merged commit fb376a1 into quicksilver:master Jun 22, 2011
@skurfer
Copy link
Member

@skurfer skurfer commented Jun 22, 2011

So it has.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants