Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed iObject actions showing for dObject when closing/reopening QS #384

Merged
merged 2 commits into from Jun 17, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 17, 2011

This is the bug where if you:

a)

  • Put text in the 1st pane
  • Choose the 'find with...' action
  • Tab over to 3rd pane and hit
    ↓ a few times
  • Close/Reopen QS
  • Quicksilver thinks the dObject has the type of whatever was last in the iObject pane

b)
*Same for URLs and open url With...

Can you believe it was this stupid a bug?! Damn I hate finding things like this... fortunately only took me 20 minutes or so :)

Incidentally, my housemate asked me how many lines of code I had to look through, turns out QS is ~219282 lines of code :D

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jun 17, 2011

I thought this one letter change was looking a bit lonely.
I've added another commit that removes the OS 9 applications catalog entry. Kinda pointless in 2011 dotcha think?

@skurfer
Copy link
Member

@skurfer skurfer commented Jun 17, 2011

I've added another commit that removes the OS 9 applications catalog entry. Kinda pointless in 2011 dotcha think?

Pfft. OS 9 applications were pointless in 1998. :)

All looks good to me.

skurfer added a commit that referenced this issue Jun 17, 2011
Fixed iObject actions showing for dObject when closing/reopening QS
@skurfer skurfer merged commit 47e99b7 into quicksilver:master Jun 17, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants