Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added error checking and steps so packages (e.g. .app, .qsplugin) are not #443

Merged
merged 3 commits into from Aug 9, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 25, 2011

Basically I've just done a check for the NSURLIsPackageKey (Snow Leopard+ only)

Previously, .app and other packages would be ignored as they were thought to be folders. This stops that.

I've also changed the error:nil code to actually store, then check for an NSError

if ([downloadedFile getResourceValue:&isPackage forKey:NSURLIsPackageKey error:&err] && ![isPackage boolValue]) {
if (err != nil) {
NSLog(@"Error getting resource value for %@\nError: %@",downloadPath,err);
continue;
Copy link
Member

@skurfer skurfer Aug 1, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line shouldn’t be necessary, since it’ll always hit the continue on line 55.

Copy link
Member Author

@pjrobertson pjrobertson Aug 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

don't know if you've already merged this, but if not - I'll do this when I
get home for a few days Saturday/Sunday

:)

On 1 August 2011 21:16, skurfer <
reply@reply.github.com>wrote:

@@ -36,15 +39,32 @@
[fileExtension isEqualToString:@"crdownload"])
{
continue;
}

  •                 if ([downloadedFile getResourceValue:&isDir
    
    forKey:NSURLIsDirectoryKey error:nil] && [isDir boolValue]) {
  •                         continue;
    
  •                 // Do not show folders
    
  •                 if ([downloadedFile getResourceValue:&isDir
    
    forKey:NSURLIsDirectoryKey error:&err] && [isDir boolValue]) {
  •                         if (err != nil) {
    
  •                                 NSLog(@"Error getting resource
    
    value for %@\nError: %@",downloadPath,err);
  •                                 continue;
    
  •                         }
    
  •                         // Show packages (e.g. .app and .qsplugin
    
    packages)
  •                         if ([downloadedFile
    
    getResourceValue:&isPackage forKey:NSURLIsPackageKey error:&err] &&
    ![isPackage boolValue]) {
  •                                 if (err != nil) {
    
  •                                         NSLog(@"Error getting
    
    resource value for %@\nError: %@",downloadPath,err);
  •                                         continue;
    

This line shouldnt be necessary, since itll always hit the continue on
line 55.

Reply to this email directly or view it on GitHub:
https://github.com/quicksilver/Quicksilver/pull/443/files#r79107

Copy link
Member

@skurfer skurfer Aug 5, 2011

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not merged yet. I’ll wait.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Aug 6, 2011

OK, I've made the changes and also removed the leopard stuff while we're at it.

We need to get on and get the plugins system done. :/
I've got 2 days back home... :)

skurfer added a commit that referenced this issue Aug 9, 2011
added error checking and steps so packages (e.g. .app, .qsplugin) are not
@skurfer skurfer merged commit caac166 into quicksilver:master Aug 9, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants