Fix build dmg

[tiennou]

Fix the Quicksilver Distribution target image disk packaging. Build on Release to get the disk image in the Products directory.

[skurfer]

Looks good to me. I’ll let it sit for a couple of days for others to review, then merge it.

I love that it no longer overwrites /Applications/Quicksilver.app.

[tiennou]

I love that it no longer overwrites /Applications/Quicksilver.app.

Right you are ;-).

I have a branch where I've tried to switch back to using Xcode's default for built files (instead of putting everything in /tmp/QS), but I guess it requires Xcode 4 and a Workspace file to work.

[skurfer]

I noticed that the “clean” process (⇧⌘K in Xcode 4) doesn’t remove the DMG. Is that something we can control?

[pjrobertson]

I guess it'd be good to get this merged before the next release...

Works great in XCode 3 :)
One small thing: the naming convention of the .dmg. I'm not sure how well the ß60 will play nice with everything that isn't UTF-8. I'm happy for us to start dropping the ß... perhaps just Quicksilver 61 or Quicksilver v61.

I can confirm that the .dmg isn't removed on Xcode 3

[pjrobertson]

(Other than that, I see no reason for you (skurfer) not to merge :)

[pjrobertson]

Sorry for the 3rd in a row. I see the naming is just taken straight from Developer.xcconfig, which is perfect.

I cannot see what has changed to stop the overwriting of the /Apps/QS.app file, but it's great!
I'd have assumed the first two lines in the 'install' phase (Quicksilver distribution) would have been removed?

[tiennou]

I noticed that the “clean” process (⇧⌘K in Xcode 4) doesn’t remove the DMG. Is that something we can control?

It can be controlled, but I'm really not sure how... I'll try to scour the Xcode docs for that.

I cannot see what has changed to stop the overwriting of the /Apps/QS.app file, but it's great!
I'd have assumed the first two lines in the 'install' phase (Quicksilver distribution) would have been removed?

Those are responsible of copying built QS to /Applications/Quicksilver.app. You can remove them if you will, but I had kept them just in case ;-).

[pjrobertson]

Those are responsible of copying built QS to /Applications/Quicksilver.app. You can remove them if you will, but I had kept them just in case ;-).

Sorry, I hadn't seen they were commented out... :(

For removing the .dmg on clean: http://yeahrightkeller.com/2009/run-script-while-cleaning-in-xcode/

I am happy to do that in Xcode 3 if required

[skurfer]

OK. If it’s not a straightforward, natively supported thing, I don’t think it’s work it. It’s just a tiny DMG. I know how to get rid of it if I want. I would hope anyone building from source can too. :)

[tiennou]

Quick note: I actually had the bad experience of bundling a QS ß60 in a disk image named "Quicksilver ß61". Make sure to clean before building for packaging ;-).