Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failed plugin load #532

Merged
merged 9 commits into from Nov 3, 2011
Merged

Failed plugin load #532

merged 9 commits into from Nov 3, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Oct 26, 2011

Adds support for when the app itself crashes (not just when it crashes due to plugins)

See commit messages for full descriptions

pjrobertson added 5 commits Oct 26, 2011
* Move any NSAlerts from QSApp.m:init to QSController.m:init (stops crashing on Lion)
* Implement a QSQuitGracefully preference BOOL. If this is NO, then we had a crash
* Added a dialog with three options: clear caches, do nothing, read FAQ
* Incorporated plugin crash support into overall application crash support
Typically, clicking 'Stop' in Xcode is equivalent to QS crashing (in the eyes of QS)
Conflicts:
	Quicksilver/Code-QuickStepCore/QSDefines.h
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Oct 27, 2011

The final commit here I snuck in... :)

I've basically just bumped the core support bundle versions so we know which versions are the latest.

Build: 95
Version: 0.6.2 (reflects ß62 when it's released)

@skurfer
Copy link
Member

@skurfer skurfer commented Oct 31, 2011

Are there really that many changes to the property list or did Xcode just want to rearrange the whole thing? In the past, I’ve seen it try to do something like that. I just revert the changes and do them in TextMate instead. :)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Oct 31, 2011

Is it the .plist that's causing the merge conflict? If so, I'll revert it
and then just do it manually as you've said :)

On 31 October 2011 14:20, Rob McBroom <
reply@reply.github.com>wrote:

Are there really that many changes to the property list or did Xcode just
want to rearrange the while thing? In the past, Ive seen it try to do
something like that. I just revert the changes and do them in TextMate
instead. :)

Reply to this email directly or view it on GitHub:
#532 (comment)

pjrobertson added 2 commits Oct 31, 2011
… sure the correct plugin is loaded"

This reverts commit 586e332.
Will edit the file by hand
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Oct 31, 2011

OK merge conflict fixed :)

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 1, 2011

I just cleaned out all of Quicksilver’s files in another test account I use and launched it for the first time. It warns me that it crashed previously and asks me what to do. Can you duplicate?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 1, 2011

Makes sense. If QS has never launched before then there isn't a BOOL
'QSQuitGraciously' so it thinks it crashed.
I'll make a change :)

On 1 November 2011 14:44, Rob McBroom <
reply@reply.github.com>wrote:

I just cleaned out all of Quicksilvers files in another test account I
use and launched it for the first time. It warns me that it crashed
previously and asks me what to do. Can you duplicate?

Reply to this email directly or view it on GitHub:
#532 (comment)

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 1, 2011

As long as you’re mucking with it, you think we could change this to store the state in ~/Library/Caches/?

It looks like in other places, Quicksilver just reads/writes a property list, which seems pretty easy. Search the project for @"qsindex" (with the quotes) for an example.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 1, 2011

I've fixed the 1st bug you mentioned about the dialogue popping up on first
time use.

Reading/writing a property list is indeed easy. I did it with my 1Password
module :)
But... that's exactly what [NSUserDefaults synchronise] does! It writes a
.plist.

I guess it's true that it's writing more than is really necessary (just the
plugins information), but I think having to create and write a file, then
delete it every time may be just as long.

This is all kind of 'hands in the air wavy' guess work, so I'm unsure if
it's worth the extra changes?

On 1 November 2011 15:41, Rob McBroom <
reply@reply.github.com>wrote:

As long as youre mucking with it, you think we could change this to store
the state in ~/Library/Caches?

It looks like in other places, Quicksilver just reads/writes a property
list, which seems pretty easy. Search the project for @"qsindex" (with
the quotes) for an example.

Reply to this email directly or view it on GitHub:
#532 (comment)

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 2, 2011

The issues I reported with the panel popping up at inappropriate times appear to be fixed with the latest commits. I’ll run it a bit longer, but it looks good.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 3, 2011

Sounds good :)

Basically I made sure that - before the alert was diplayed - the BOOL
actually existed (not just NO).

On 2 November 2011 19:20, Rob McBroom <
reply@reply.github.com>wrote:

The issues I reported with the panel popping up at inappropriate times
appear to be fixed with the latest commits. Ill run it a bit longer, but
it looks good.

Reply to this email directly or view it on GitHub:
#532 (comment)

skurfer added a commit that referenced this issue Nov 3, 2011
@skurfer skurfer merged commit 7c558ca into quicksilver:master Nov 3, 2011
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants