Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Command builder colors #549

Merged
merged 2 commits into from Nov 4, 2011
Merged

Command builder colors #549

merged 2 commits into from Nov 4, 2011

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Nov 2, 2011

The CommandBuilder (when you create or edit a trigger) uses colors taken from the preferences. Depending on which interface you use and which colors you set, this can make labels in the CommandBuilder difficult or impossible to read.

I’ve hard-coded the text and highlight colors to some boring, but reasonable values.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 4, 2011

I’ve hard-coded the text and highlight colors to some boring, but reasonable values.

Bah - grey is so boring!

All looks good to me.

Just some notes:

  • I thought that the task viewer colours might also need to be hard coded - it seems to be fine though
  • Clipboard/shelf should and do display the custom colours - yep.
  • results list still shows the theme colours. I see no problem with this though.
  • Damn Apple being American. It should be LightGreyColour :(

pjrobertson added a commit that referenced this issue Nov 4, 2011
@pjrobertson pjrobertson merged commit 94a2b0c into quicksilver:master Nov 4, 2011
@skurfer
Copy link
Member Author

@skurfer skurfer commented Nov 4, 2011

Damn Apple being American. It should be LightGreyColour

Feel free to subclass NSColor as NSColour and add a bunch of misspelt methods. ;-)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 4, 2011

Feel free to subclass NSColor as NSColour and add a bunch of misspelt
methods. ;-)

Good plan, I'll work on it tonight!

On 4 November 2011 13:18, Rob McBroom <
reply@reply.github.com>wrote:

Damn Apple being American. It should be LightGreyColour

Feel free to subclass NSColor as NSColour and add a bunch of misspelt
methods. ;-)


Reply to this email directly or view it on GitHub:
#549 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants