Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initialize ivars in init. #561

Merged
merged 2 commits into from Nov 9, 2011
Merged

Initialize ivars in init. #561

merged 2 commits into from Nov 9, 2011

Conversation

tiennou
Copy link
Member

@tiennou tiennou commented Nov 9, 2011

Prevents a crash at startup since plugins get loaded before the catalog is fully initialized, causing -writeCatalog: to fail since the ivar is nil.

I'm not sure what happenned here, but today it showed up, asking me kindly to remove faulty plugins one after the other ;-).

tiennou added 2 commits Nov 9, 2011
Prevents a crash at startup since plugins get loaded before the catalog is fully initialized,  causing -writeCatalog: to fail since the ivar is nil.
@pjrobertson pjrobertson mentioned this pull request Nov 9, 2011
@skurfer
Copy link
Member

@skurfer skurfer commented Nov 9, 2011

Looks good.

skurfer added a commit that referenced this issue Nov 9, 2011
@skurfer skurfer merged commit c38eba9 into quicksilver:master Nov 9, 2011
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 9, 2011

FWIW: Seconded. Looks good from me as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants