-
Notifications
You must be signed in to change notification settings - Fork 286
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Process monitor updates #575
Process monitor updates #575
Conversation
- Use Carbon for monitoring. NSWorkspace only handles non-background applications. - Processes are now cached in a dictionary keyed by PSN, loaded the first time you ask for the process list. This means the process list is always up to date now w.r.t background processes, since notifications are now seen for background processes. - Check the process dictionary for process info on termination (that's the only place we can get it, since the process itself is no longer running). - Remove most of the stuff from the header (most of those are private stuff that shouldn't have been exported in the first place). - Reimplement -allProcesses, -visibleProcesses and their -get* variants using the new process list.
…only in the object source.
I keep a copy of the old repo that had all plug-ins for checking things like this. I only found one that looks for |
I don't know, I would say maybe some users what to keep the cruft out of their process list ? I'm not really found of seeing 'loginwindow' show up in that list. I agree on the checkbox, I just kept it for discussion with users first ;-). Another way would be to split the "Applications & Process" Catalog into "Applications" & "Background Processes", so that users have more control over what gets indexed. This would add more visibility to that setting... |
I'm all about simplifying preferences. Eliminate any preference checkbox that you possible can. So I say: Remove the checkobx, always include background processes and the users will get used to it. It will still be just as quick to select the app you want. |
Maybe the Catalog item could be splat in "Applications" & "Background Processes" ? I'm all in favor of dropping the checkbox, but I don't like changing user habits (and its a little checkbox in an oft-used drawer after all ;-)). |
I guess I'd be ok with that. More obvious than the little checkbox in an often-used drawer. Still a preference, but better than before. :-) Btw. is "splat" really a word? ;-) |
Le 19 nov. 2011 à 21:51, Henning Jungkurth a écrit :
Haha, that's what you get trying to use Old English word without knowing what they mean ! I though oft meant its exact opposite ;-).
Split, splat, splat ? ;-P |
So...are you gonna splatter it up? ;-) |
I've been in favour of dropping the checkbox all together for a while now. Just has a user report a bug about the 'problem' (#635) Maybe 2 catalog entries with the checkbox dropped would work fine as well :) |
I see no problems with this 'as is', except for the matter of the background processes checkbox, but it's not a show stopper. Any objections from others to this being merged? I'm a bit wary of just dropping the @"processesChanged" notification, but @skurfer has done a check and it seems to be unused. |
I’ve just been waiting for the UI changes before merging this, but I’m guessing @tiennou is busy. I’ve been using this since it was submitted without issue. No objections to merging. |
One of us can probably make the UI changes. I'll merge this now. |
This is major surgery on QSProcessMonitor ;-).
I made it always keep the list of process up-to-date by building the full list in -reloadProcesses (aka the first scan on startup), and then the appLaunched/Terminated notifications ensure that the list is always up to date.
The responsibility of indexing background apps has been moved to QSProcessSource, and this last one had been made to observe QSProcessMonitor -allProcesses array (instant reindex when something launches/quits !). Also, the necessity to restart QS when you fiddle with the "Show Background Application" checkbox is gone (its observed by QSProcessSource).
A few things to note :
This is related to #453, and another one which I can't find anymore (related to background apps only getting scanned once at startup).