Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made sure the 'clear caches' button in the crash dialogue only removes catalog caches #582

Merged
merged 3 commits into from Nov 17, 2011

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Nov 17, 2011

Use the path as defined in QSPaths.m and only remove the catalog caches (so as to save the QuicksilverState.plist file)

As pointed out by @HenningJ

HenningJ added a commit that referenced this issue Nov 17, 2011
Made sure the 'clear caches' button in the crash dialogue only removes catalog caches
@HenningJ HenningJ merged commit f3eea29 into quicksilver:master Nov 17, 2011
@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Nov 17, 2011

yay :-)

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 22, 2011

So I’m late to this, but since there seem to be problems surrounding the relaunch/crash dialog, I’ll ask: Why can’t the state file be removed? The app should be perfectly happy to launch without it (and not think there was a crash). Is this for the scenario where there are multiple crashes in a row?

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 22, 2011

I thought exactly the same thing yesterday, but the state file can contain
data on the plugin crash status. So if we just blow it away without knowing
if a plugin's caused a crash that can't be good.

I agree that in applicationWillTerminate in QSController.m we can just
delete the file all together.

On 22 November 2011 13:58, Rob McBroom <
reply@reply.github.com

wrote:

So Im late to this, but since there seem to be problems surrounding the
relaunch/crash dialog, Ill ask: Why cant the state file be removed? The
app should be perfectly happy to launch without it (and not think there was
a crash). Is this for the scenario where there are multiple crashes in a
row?


Reply to this email directly or view it on GitHub:
#582 (comment)

@HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Nov 22, 2011

Is this for the scenario where there are multiple crashes in a row?

Exactly. I ran into this when testing the "clear cashes" button. I only got the crash dialog every second time I crashed QS, because it deleted the state file and the next time I crashed it, QS thought was launching for the first time.

@skurfer
Copy link
Member

@skurfer skurfer commented Nov 22, 2011

I thought exactly the same thing yesterday, but the state file can contain data on the plugin crash status.

But if the crash was due to a plug-in, you’d see a different message (without the Clear Caches button), right? Henning’s answer makes more sense. :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants