Get selection jump

[pjrobertson]

If you use ⌘⎋ to get an object, QS should really honour your 'jump to action when getting results' preference setting. It now does.

The code I've added is basically a copy/paste of Rob's code in QSInterfaceController.m:537-540

[pjrobertson]

Dammit, we're too slow at merging in my pull requests!

If you merge this, it'll merge #641. It's really small as well.

[skurfer]

Dammit, we're too slow at merging in my pull requests!

There are a few that I would merge, but the latest discussion on them imply that the submitter has a couple of small tweaks to make. But hey, that #497 looks like it’s ready. ;-)

I’ve looked at the code in #641 and it looks fine. I’ll give it a test.

[pjrobertson]

But hey, that #497 looks like its ready. ;-)

So it is. I did say it wouldn't be soonish! :P

I'll take a look over the iTunes plugin, then that pull

On 18 January 2012 16:22, Rob McBroom <
reply@reply.github.com

wrote:

Dammit, we're too slow at merging in my pull requests!

There are a few that I would merge, but the latest discussion on them
imply that the submitter has a couple of small tweaks to make. But hey,
that #497 looks like its ready. ;-)

Ive looked at the code in #641 and it looks fine. Ill give it a test.

---

Reply to this email directly or view it on GitHub:
#643 (comment)

[pjrobertson]

I'm going to change this to call a method that does what is required, hold yer horses ;-)

[pjrobertson]

OK this is ready :-)

[pjrobertson]

Hold yer horses one last time!
http://groups.google.com/group/blacktree-quicksilver/browse_thread/thread/a2886bd8f98d7421# has made me want to change this again!

[skurfer]

Horses held. (I have been testing it though.)

[pjrobertson]

OK, I've committed another few changes. Basically, I've deleted the new
method I made and reverted to the existing method (didn't know it existed)
called actionActivate - this should make sure that QS is consistent
everywhere - will only activate the action pane if specified.

Only other place actionActivate is used is QSCommand.m for - (void
)executeFromMenu:(id)sender {

Seems to work for this as well.

On 20 January 2012 18:09, Rob McBroom <
reply@reply.github.com

wrote:

Horses held. (I have been testing it though.)

---

Reply to this email directly or view it on GitHub:
#643 (comment)

[skurfer]

Looks good. I’ll run with it for a while.