Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Get selection jump #643

Merged
merged 7 commits into from Jan 31, 2012
Merged

Get selection jump #643

merged 7 commits into from Jan 31, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jan 18, 2012

If you use ⌘⎋ to get an object, QS should really honour your 'jump to action when getting results' preference setting. It now does.

The code I've added is basically a copy/paste of Rob's code in QSInterfaceController.m:537-540

pjrobertson added 5 commits Jan 17, 2012
Reproduce:

* Copy the 'Run (Applescript)' action from the 2nd pane (when an AS is in the 1st pane)
* Type an invalid path in the 1st pane (e.g. /abc/) and paste the action in the 2nd pane

I came across this when a trigger was pointing to a changed location.
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 18, 2012

Dammit, we're too slow at merging in my pull requests!

If you merge this, it'll merge #641. It's really small as well.

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 18, 2012

Dammit, we're too slow at merging in my pull requests!

There are a few that I would merge, but the latest discussion on them imply that the submitter has a couple of small tweaks to make. But hey, that #497 looks like it’s ready. ;-)

I’ve looked at the code in #641 and it looks fine. I’ll give it a test.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 18, 2012

But hey, that #497 looks like its ready. ;-)

So it is. I did say it wouldn't be soonish! :P

I'll take a look over the iTunes plugin, then that pull

On 18 January 2012 16:22, Rob McBroom <
reply@reply.github.com

wrote:

Dammit, we're too slow at merging in my pull requests!

There are a few that I would merge, but the latest discussion on them
imply that the submitter has a couple of small tweaks to make. But hey,
that #497 looks like its ready. ;-)

Ive looked at the code in #641 and it looks fine. Ill give it a test.


Reply to this email directly or view it on GitHub:
#643 (comment)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 19, 2012

I'm going to change this to call a method that does what is required, hold yer horses ;-)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 19, 2012

OK this is ready :-)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 20, 2012

Hold yer horses one last time!
http://groups.google.com/group/blacktree-quicksilver/browse_thread/thread/a2886bd8f98d7421# has made me want to change this again!

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 20, 2012

Horses held. (I have been testing it though.)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jan 20, 2012

OK, I've committed another few changes. Basically, I've deleted the new
method I made and reverted to the existing method (didn't know it existed)
called actionActivate - this should make sure that QS is consistent
everywhere - will only activate the action pane if specified.

Only other place actionActivate is used is QSCommand.m for - (void
)executeFromMenu:(id)sender {

Seems to work for this as well.

On 20 January 2012 18:09, Rob McBroom <
reply@reply.github.com

wrote:

Horses held. (I have been testing it though.)


Reply to this email directly or view it on GitHub:
#643 (comment)

@skurfer
Copy link
Member

@skurfer skurfer commented Jan 20, 2012

Looks good. I’ll run with it for a while.

skurfer added a commit that referenced this issue Jan 31, 2012
@skurfer skurfer merged commit 356e3c9 into quicksilver:master Jan 31, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants