Show catalog source

[pjrobertson]

Updated pull request for #672 to avoid a merge conflict.

Once this is merged and changing the Info.plist 'File Type' to 'Info plist XML' I'll update the rest of the Info.plist files in the repo

[skurfer]

I think you added validatesObjects to the wrong entry. Should be under QSObjectShowSourceAction, right?

[pjrobertson]

I knew I did this too fast... apologies for doing so, but kudos for spotting it!

Having reverted the commit, I tried to re-edit the Info.plist in Xcode but git was complaining the whole file was changed. Seems like changing the type didn't work. If you have any ideas, then that'd be good. I'm stumped.

[skurfer]

I have two: Vim and TextMate. ;-)

[pjrobertson]

TextMate is my best friend on this one as well :)

[skurfer]

TextMate is my best friend on this one as well

If you fixed this by hand, I’m not seeing the additional commits. :-)

[pjrobertson]

Can you not see 70ac6e9 and 3724118 ?

The first reverts my previous (wrong) commit that edited the Info.plist with the second being my edit using TM

[skurfer]

Oh, sorry. I was looking at the diff that claimed over 4000 changes thinking Xcode had rearranged the file, but it was just the format change. I’ll give it another quick test and merge if it looks OK.

[skurfer]

Found another bug (not affected by this change). If you launch QS and try to use Show Source in Catalog on something, it could hang, crash, or do nothing. If, on the other hand, you open the Preferences panel and close it again first, the action works fine until the next relaunch.