Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dock icon visibility prefs - fixes #686, #689 #690

Merged
merged 4 commits into from Feb 10, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 6, 2012

These changes alter the way in which Quicksilver looks at the dock icon, and makes this much, much simpler.

Previously, Quicksilver would try and change the LSUIElement BOOL in the .app's Info.plist. This would mean non-admin users could not change this setting, and were 'stuck'.

With the change we made in ß63 to have LSUIElement set to TRUE in the Info.plist (72e2ced) there is actually now no need to fiddle with the BOOL in the Info.plist, and Quicksilver can respect the settings in the user's com.blacktree.Quicksilver.plist file.

Upsides: A lot of un-needed code fiddling with the Info.plist and checking if it's writable can be removed. And non-admin users can toggle the settings

Downside: For users that have the dock icon set to show, the showDockIcon method is run every time Quicksilver launches. Previously, it'd be run once to set the Info.plist LSUIElement BOOL. This isn't really a downside I don't think. On the whole, it's a major simplification.

pjrobertson added 3 commits Feb 6, 2012
Since the UIElement BOOL in QS's Info.plist is set to TRUE as of ß63, there is no need to actually edit the Info.plist file to toggle the visibility of the dock icon.

This means that non-admin users can now edit the preference and life is much simpler
@pjrobertson pjrobertson mentioned this pull request Feb 6, 2012
@skurfer
Copy link
Member

@skurfer skurfer commented Feb 10, 2012

Tested various scenarios with a clean non-admin account. All seems to work as it should. This’ll be a nice addition.

skurfer added a commit that referenced this issue Feb 10, 2012
Dock icon visibility prefs - fixes #686, #689
@skurfer skurfer merged commit 87afee4 into quicksilver:master Feb 10, 2012
@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Feb 10, 2012

Great stuff. I spent ages trying to figure out how to get this to work for non-admin users. Turns out the fix was simply to remove a ton of code :)

ß65 pre?

@skurfer
Copy link
Member

@skurfer skurfer commented Feb 10, 2012

ß65 pre?

I wouldn’t mind also including your “show catalog source” fix since it’s small and prevents potential crashes. I’ll go look at it again. I also would like to get the shelf/clipboard fix in if we can, since it’s a one-line change. But if you don’t want to wait for those things, I’m fine with a pre-release now.

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Feb 10, 2012

I also would like to get the shelf/clipboard fi in if we can, since its
a one-line change.

I was going to try and test/get it in, as there's been a bit of buzz about
it lately. I'll look at it now.

On 10 February 2012 15:20, Rob McBroom <
reply@reply.github.com

wrote:

65 pre?

I wouldnt mind also including your show catalog source fix since its
small and prevents potential crashes. Ill go look at it again. I also
would like to get the shelf/clipboard fi in if we can, since its a
one-line change. But if you dont want to wait for those things, Im fine
with a pre-release now.


Reply to this email directly or view it on GitHub:
#690 (comment)

@ghost
Copy link

@ghost ghost commented Nov 24, 2012

Still in dock ß70 (3935).

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Nov 26, 2012

ß71 (out soon) should make a few more changes that potentially fix this. Please wait until that is out and let us know.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants