Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Execute commands consistently #699

Merged
merged 6 commits into from Feb 23, 2012
Merged

Execute commands consistently #699

merged 6 commits into from Feb 23, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Feb 14, 2012

This contains fixes for #623 and #670.

Long story short, you couldn’t have a trigger for something like “Finder Selection → Compress”. Now you can.

The problem was that there were different places that could execute an action and they didn’t all behave the same way. Rather than duplicate code, I’ve attempted to move things around so the same code is used no matter how an action is run.

I initially didn’t like QSommand doing so much with the interface controller, but I’ve talked myself into it. I can go into more detail if anyone is similarly uneasy.

I’ve tried executing things every way I can think of (using the interface, triggers, droplets, encapsulated commands, commands saved to disk, commands run after delay) and they all seem to function correctly.

skurfer added 5 commits Jan 31, 2012
`executePartialCommand:` and `performOnDirectObject:indirectObject:` were each being called in two different places
Previously, these actions would only work correctly if run by the user from the interface. Now they should work in other contexts.

fixes #623
@pjrobertson pjrobertson mentioned this pull request Feb 18, 2012
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 19, 2012

Funny I should only stumble upon this now after years of QS use, just as you've open this...

Seems like #670 also applies to objects grabbed with ⌘⎋. Would it be possible to fix that? Should be pretty easy I imagine. The ⌘⎋ command runs the receiveObject method in QSController.m. I came across it when fixing the getSelectionJump pull #643

@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 19, 2012

Seems like #670 also applies to objects grabbed with ⌘⎋. Would it be possible to fix that?

Same goes for things opened with the qs command-line tool. I’ll see if I can fix them both.

@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 20, 2012

I’ll see if I can fix them both.

Done. :-)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 20, 2012

Oooh the command line tool. Never actually used that. Any good?

This all looks good. i'll keep playing

@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 21, 2012

Oooh the command line tool. Never actually used that. Any good?

Yeah, I forget it’s there most of the time, but I’ve rediscovered it in the past couple of weeks. It’s pretty cool. One time I love having it is when I’m in a plug-in’s directory doing git stuff and I want to open the Xcode project. There are lots of ways to do it, but the fastest I’ve found is to just run qs ., then hit / to go into the folder, at which point it’s pretty easy to find the project file.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 23, 2012

I see the problem with the current command line tool. I'm assuming your change over there fixes it.

Other than that, everything looks good.

P.S. I use a different method to you for getting e.g. the current folder/file/whatever in terminal/whatever.
With the User Interface Access module install, I have a trigger for Current DocumentSelect in Command Window.

I think this is probably my most used thing in Quicksilver since neurolepsy introduced it a year or so ago. You can use it on practically anything: Safari URLs, Terminal Windows, non-cocoa apps (MS Word etc.), Preview...

pjrobertson added a commit that referenced this issue Feb 23, 2012
Execute commands consistently
@pjrobertson pjrobertson merged commit e6ae4d6 into quicksilver:master Feb 23, 2012
@skurfer
Copy link
Member Author

@skurfer skurfer commented Feb 23, 2012

I see the problem with the current command line tool. I'm assuming your change over there fixes it.

Yep.

You can use it on practically anything: Safari URLs, Terminal Windows, non-cocoa apps (MS Word etc.), Preview...

Wow. I knew it was good, but I didn’t know it worked on Terminal’s current directory. I wonder if it’s only because we have it in the title bar? Anyway, cool.

BTW, my favorite new trigger (now that this is merged): Finder Selection → Get Path (scoped to Finder only)

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Feb 23, 2012

I wonder if it’s only because we have it in the title bar?

I think so, I've thought it was to do with the title bar as well.

BTW, my favorite new trigger (now that this is merged): Finder Selection
→ Get Path (scoped to Finder only)

I wonder how many amazing triggers there are that not even we will
discover... :)

On 23 February 2012 20:23, Rob McBroom <
reply@reply.github.com

wrote:

I see the problem with the current command line tool. I'm assuming your
change over there fixes it.

Yep.

You can use it on practically anything: Safari URLs, Terminal Windows,
non-cocoa apps (MS Word etc.), Preview...

Wow. I knew it was good, but I didn’t know it worked on Terminal’s current
directory. I wonder if it’s only because we have it in the title bar?
Anyway, cool.

BTW, my favorite new trigger (now that this is merged): Finder Selection →
Get Path (scoped to Finder only)


Reply to this email directly or view it on GitHub:
#699 (comment)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants