Join GitHub today
Ensure large type text is sized based on screen HEIGHT as well as width #733
Also, change the string name from
If you have a string that is really really long, or has many lies, then Quicksilver would previously not set the font size to ensure all the lines are included in the large type display.
e.g. paste this into QS's 1st pane before, and after this fix.
I was unsure about that 2*EDGEINSET bit as well, but I considered the 'if
Perhaps when Rob looks at merging all this into one global method (as he
To be perfectly honest, I have no idea what a descender/ascender is (of
On 27 February 2012 14:17, Henning Jungkurth <
I noticed one small thing. If you have a narrow column of text, the Large Type display is still very wide. For instance, try
I don’t think that should hold this up, so I’ll merge it as is, but… Just in case you plan to fix it and would prefer to do it on this existing branch, I’ll give you a few hours to speak up before I merge.
I am looking into this now, thanks for holding off!
Been busy watching Wales win the Grand Slam - rugby :)
On 17 March 2012 14:49, Rob McBroom <
Definitely better for narrow columns, but now I see other weirdness.
The shadow for some taller characters looks like it’s getting cut off at the bottom (You may have to look at it full size. See the
If the text being displayed has some leading whitespace, the position gets weird:
This message would have been much easier to put together with a Dropbox plug-in to grab those links for me. ;-)