Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't jump to the second pane unnecessarily #784

Merged
merged 1 commit into from Mar 30, 2012
Merged

don't jump to the second pane unnecessarily #784

merged 1 commit into from Mar 30, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Mar 30, 2012

Finally fixed #283.

The call that was removed would only be reached in very rare circumstances.

  1. “Run tasks in background” must be disabled
  2. When hitting return to run the action, you must be in text mode.
  3. The default action that gets run must display results.

I can’t imagine why that should have triggered a jump to the second pane. This behavior goes back to the initial commit.

If having “Run tasks in background” doesn’t trigger this behavior, and escaping out of text mode before hitting return doesn’t trigger it, it’s hard to make a case that it’s necessary.

pjrobertson added a commit that referenced this pull request Mar 30, 2012
don't jump to the second pane unnecessarily
@pjrobertson pjrobertson merged commit e929e52 into quicksilver:master Mar 30, 2012
@pjrobertson
Copy link
Member

pjrobertson commented Mar 30, 2012

Good hunting.

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent 2nd pane focusing when UI is set to re-appear
2 participants