Added a means to see which search mode is in use (tick and name in resul... #786
Conversation
…sults view) as well as keyboard shortcuts ⌘→ and ⌘← for switching search modes. Fixes quicksilver#413. Fixes quicksilver#67
removes dependence on things in /Developer
|
I don’t see the use case myself, but this seems to work. I like the way the mode is displayed above the results. Makes it much more “discoverable” I think. |
Get real localised names of display and fix quicksilver#789
| // } | ||
| // else { | ||
| // searchMode = newSearchMode; | ||
| // } |
There was a problem hiding this comment.
What's with all the commented code here? Shouldn't it be removed if it isn't used anymore?
There was a problem hiding this comment.
I don't know what this did. The problem with it being too long ago!
I've removed it now, new commits
|
I really like this. Works great. My comments in the code are more about style than function. |
more fixes for Xcode 4.3
|
Thanks for the comments Henning. I've changed both things. I built this just now to test my changes for the first time since 8 months ago and wow - this is so useful! :P |
|
The first two commits here are just a merge into master to eliminate the merge conflict |
|
Nothing to do with this pull request, but I’m curious why anyone would ever use “Snap to Best” mode at all. “Filter Results” always puts the best match in the first pane with the added benefit that it, you know, filters results. I run with that mode at all times and never feel like I’m missing anything. |
|
From Howard's manual:
I've never used it before in my life. I guess it could be useful if you just want to 'check' if something's in the results, maybe? :P Are you suggesting we remove it? Could do I s'pose. Maybe it's worth asking in the user groups what people use it for? |
No, just trying to understand. It’s the default, so I’m sure quite a lot of people are used to things working that way. |
Imagine you're browsing a folder, want to find a specific file, and then look at all the files around it. Or something. I don't really use it either. |
|
This is ready for merge in my opinion. Any outstanding issues? |
|
Not that I know of. I don't plan on adding anything :) |
Added a means to see which search mode is in use (tick and name in resul...
|
Merged. |
...ts view) as well as keyboard shortcuts
⌘→ and ⌘← for switching search modes.
Fixes #413. Fixes #67
Seems like this pull request has been hanging around for ages. Not sure why it was never made. I think it was back in the day when I was going away and I made a long list on the dev groups of all my 'outstanding' pull requests.
There may be a merge conflict as it's so old, but #67 gives pretty much all the information you need.