Display DEBUG and git branch in QS versions string #829
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is great, though I never get the “Debug” string. I’m trying to figure out if |
|
Looks like Xcode 4 puts that in a variable called |
|
Ok, |
skurfer
added a commit
that referenced
this pull request
Apr 24, 2012
Display DEBUG and git branch in QS versions string
|
All looks good. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We discussed this in a thread in the developers mailinglist: With this change, the version string of QS will contain the name of the git branch you're on when you built QS and if you did a DEBUG build or not. This helps developers to know which custom version of QS they are currently running. It doesn't change anything for end-users.
The format is a Rob suggested:
I implemented this by adding a build phase at the end of the Quicksilver target that changes Quicksilver.app's
Info.plistto reflect the new version string format.