Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display DEBUG and git branch in QS versions string #829

Merged
merged 3 commits into from Apr 24, 2012

Conversation

HenningJ
Copy link
Contributor

@HenningJ HenningJ commented Apr 19, 2012

We discussed this in a thread in the developers mailinglist: With this change, the version string of QS will contain the name of the git branch you're on when you built QS and if you did a DEBUG build or not. This helps developers to know which custom version of QS they are currently running. It doesn't change anything for end-users.
The format is a Rob suggested:

Debug build from CpMac: ß66:CpMac:Debug
Release build from CpMac: ß66:CpMac
Release build from master (or release): ß66

I implemented this by adding a build phase at the end of the Quicksilver target that changes Quicksilver.app's Info.plist to reflect the new version string format.

@skurfer
Copy link
Member

@skurfer skurfer commented Apr 23, 2012

This is great, though I never get the “Debug” string. I’m trying to figure out if BUILD_STYLE changed in Xcode 4 or something.

@skurfer
Copy link
Member

@skurfer skurfer commented Apr 23, 2012

Looks like Xcode 4 puts that in a variable called CONFIGURATION instead.

@HenningJ
Copy link
Contributor Author

@HenningJ HenningJ commented Apr 24, 2012

Ok, CONFIGURATION exists in XCode 3 as well. Changed it.

skurfer added a commit that referenced this issue Apr 24, 2012
Display DEBUG and git branch in QS versions string
@skurfer skurfer merged commit eecbd6d into quicksilver:master Apr 24, 2012
@skurfer
Copy link
Member

@skurfer skurfer commented Apr 24, 2012

All looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants