Updated Crash reporter

[pjrobertson]

This crash reporter reports crashes based on:

• Plugins that didn't load
• If the OS created a new Quicksilver.crash file in the ~/Library/Logs/CrashReporter

It's much improved over the last one and shouldn't give any false positives. It also has the following features:

• Sends crash reports to the QSApp server
• Allows for user comments to try and reproduce the problem
• Clears the QS caches automatically
• Provides access to the FAQ and Issue tracker should the user with to see them
• Looks Sexy
• Improves load time of plugin (as less writing is required to the QuicksilverState.plist file)

I suggest that reviewers of the code don't look through the commits of the QSCrashReporterWindowController files, since they're completely new. Just see the end products.

To simulate a crash, alter the lastKnownCrashDate in the com.blacktree.Quicksivler.plist prefs file to be some time in the past. E.g. to be 21 Apr 2008 00:28:24

To simulate a plugin crash, alter ~/Library/Caches/Quicksilver/QuicksilverState.plist to include the name of a plugin and a path such as (for the Cyberduck Module):

<?xml version="1.0" encoding="UTF-8"?>
<!DOCTYPE plist PUBLIC "-//Apple//DTD PLIST 1.0//EN" "http://www.apple.com/DTDs/PropertyList-1.0.dtd">
<plist version="1.0">
<dict>
    <key>QSFaultyPluginPath</key>
    <string>/Users/name/Library/Application Support/Quicksilver/PlugIns/com.blacktree.Quicksilver.Cyberduck.36.qsplugin</string>
    <key>QSFaultyPluginName</key>
    <string>Cyberduck Module</string>
</dict>
</plist>

The server side code used to receive the file is as follows (please check there are no security loop holes in this)

<?php
$file = "reports/".$_POST['name'];
$fh = fopen($file, 'w') or die("can't open file");
$userComments = "User Comments: ".$_POST['comments']."\n\n\n------------------ CRASH REPORT -----------------\n\n\n";
$stringData = $_POST['data'];
fwrite($fh, $userComments.$stringData);
fclose($fh);
?>

[pjrobertson]

Some pictures:
http://d.pr/i/NtOy for typical crashes
http://d.pr/i/QU51 for plugin crashes

[HenningJ]

I'd love to see some more comments/documentation.
And I think the server side code does need some work

But I'll look it over more thoroughly tomorrow.

[pjrobertson]

I have added comments and improved the robustness of the PHP script. QS now also sends a useful User-Agent string to the server

To view the changes to the script, please either see the file at qs0/crashreports/reporter.php on the server (if you have access) or direct message me on IRC: irc.freenote.net#quicksilver (user pjrobertson)
I am not showing it here for security reasons.

[skurfer]

I seem to be getting a false positive here. If you install a new plug-in, the next time you launch QS, it claims that plug-in caused a crash.

Also, maybe “Delete Plugin” should be a checkbox, and the delete will take place when you click one of the Send/Don’t Send buttons. It seems weird to me that I have to click two buttons (or close the panel manually). But I can see why you don’t want the button to dismiss the window. What if the user wants to delete the plug-in and send a report?

[skurfer]

If (only if) we find something else that needs to be changed, maybe add a newline here?

[skurfer]

OK, I’m happy.