Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

call attention to plug-ins that fail to load #862

Merged
merged 2 commits into from May 3, 2012
Merged

call attention to plug-ins that fail to load #862

merged 2 commits into from May 3, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented May 3, 2012

While messing with QSRequirements, I noticed that there’s a nice message in the status for plug-ins that can’t load, but there’s nothing to indicate this unless you go looking at statuses.

I’ve changed two things:

  1. The Disabled category now shows plug-ins that are installed, but not loaded. To put it another way, it shows all plug-ins that are disabled for any reason, not just those that were disabled by the user.
  2. The name of these plug-ins will be gray (or whatever color is used for “disabled” text).

There’s some weirdness where a manually disabled plug-in doesn’t appear on the Disabled list until the next launch, but that’s because isLoaded is still true. If a plug-in is still loaded, it shouldn’t appear on the Disabled list. Perhaps disabled plug-ins should be unloaded immediately, but that’s a separate issue.

skurfer added 2 commits May 3, 2012
If `loadError` is not nil, the "Enabled" property for the plug-in's name will be NO. Disabling the name doesn't really do anything. It's just a quick hack to change the appearance to indicate something is different about this plug-in. A detailed message is available in the status.
pjrobertson added a commit that referenced this issue May 3, 2012
call attention to plug-ins that fail to load
@pjrobertson pjrobertson merged commit 59eb1b4 into quicksilver:master May 3, 2012
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 3, 2012

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants