Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "If the current actions array and the new actions array are the s... #866

Merged
merged 1 commit into from May 7, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 7, 2012

...ame, don't update the 2nd pane"

Revert an over-ambitious optimisation
This reverts commit b7a9a87.

The optimisation meant that if the 1st pane object was the same (hadn't changed) or the sam type (e.g. web searches) the lift of actions wasn't getting updated.

This was causes the following two problems:

  • The action icon was not updating properly
  • 3rd pane contents were not being updated

…e same, don't update the 2nd pane"

Revert an over-ambitious optimisation
This reverts commit b7a9a87.
skurfer added a commit that referenced this pull request May 7, 2012
Revert "If the current actions array and the new actions array are the s...
@skurfer skurfer merged commit c1ba004 into quicksilver:master May 7, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants