Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix obsolete plug-in system #875

Merged
merged 5 commits into from May 10, 2012
Merged

Fix obsolete plug-in system #875

merged 5 commits into from May 10, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented May 10, 2012

This fixes some issues we’re seeing in the B68 pre-release.

  • Obsolete plug-ins will now be recognized even if they aren’t available for download.
  • New plug-ins that make others obsolete will be recognized even if they aren’t locally installed.

And some enhancements:

  • QS will only attempt to remove obsolete plug-ins once (on launch).
  • If installing a plug-in that makes a locally installed plug-in obsolete, notify the user that they should relaunch.

Note that this will get merged to the release branch. The build number will need to be bumped after it’s merged. (I didn’t do it here because this is based on master and would cause a merge conflict.)

skurfer added 5 commits May 10, 2012
Previously, only locally installed and loaded plug-ins would be checked.
Previously, only plug-ins available for download would be checked. We
don't care if those are obsolete. We only care about those installed.
Also, ensure that a plug-in is only removed if the one that replaces it
is also installed. It *shouldn't* be necessary, but is here as an
additional safety check. (In practice, if the new plug-in wasn't
installed, the obsoletePlugIns dict should be empty on launch, when
this method runs.)
pjrobertson added a commit that referenced this issue May 10, 2012
@pjrobertson pjrobertson merged commit e5a07fe into quicksilver:release May 10, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants