Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix crash on writing catalog to disk #880

Merged
merged 2 commits into from May 13, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 11, 2012

When writing the catalog .plist to disk, don't let the catalog itself be edited.

This fixes the following crash:

Exception Type:  EXC_BREAKPOINT (SIGTRAP)
Exception Codes: 0x0000000000000002, 0x0000000000000000

Application Specific Information:
objc[504]: garbage collection is OFF
*** Terminating app due to uncaught exception 'NSGenericException', reason: '*** Collection <__NSCFDictionary: 0x90dc210> was mutated while being enumerated.'
*** Call stack at first throw:
(
    0   CoreFoundation                      0x9a80eb67 __raiseError + 231
    1   libobjc.A.dylib                     0x94912149 objc_exception_throw + 155
    2   CoreFoundation                      0x9a80e651 __NSFastEnumerationMutationHandler + 177
    3   CoreFoundation                      0x9a74a26d -[__NSFastEnumerationEnumerator nextObject] + 429
    4   Foundation                          0x936835e6 _NSIsPList + 707
    5   Foundation                          0x9368363c _NSIsPList + 793
    6   Foundation                          0x936834ef _NSIsPList + 460
    7   Foundation                          0x936ffcc1 -[NSArray(NSArray) writeToFile:atomically:] + 61
    8   QSCore                              0x000a0f30 -[QSCatalogEntry saveIndex] + 255

skurfer added a commit that referenced this pull request May 13, 2012
Fix crash on writing catalog to disk
@skurfer skurfer merged commit 32a3b0f into quicksilver:master May 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants