Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't clear the field editor for the 3rd pane. Fixes #883 #885

Merged
merged 3 commits into from May 13, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented May 13, 2012

The 3rd pane behaves differently to the 1st pane, so don't clear the search editor if the new object being set is nil. Times when this is required is when the 3rd pane is taking input from the clipboard or search clipboard.

Also, my attempt at over-optimising in f113ef6 meant that should the 1st pane object be the same, the action and hence 3rd pane weren't being updated properly

pjrobertson added 3 commits May 13, 2012
The 3rd pane behaves differently, as it holds onto text from the clipboard/search clipboard
The object must be updated even if it is the same object so that the actions and hence 3rd pane can be updated accordingly
skurfer added a commit that referenced this issue May 13, 2012
Don't clear the field editor for the 3rd pane. Fixes #883
@skurfer skurfer merged commit c13ea91 into quicksilver:release May 13, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants