ß69: Replace UKKQueue with more modern version (VDKQueue)

[pjrobertson]

Whilst testing 64 bit QS, I got several NSInteger/int crashes, which turned out to be because of UKKQueue.

Fortunately I managed to find a modernised, GCD/64 bit fork. I have added this as a submodule and converted the code.
In the process, I had to tidy up a few areas which led me to the task viewer (and all its problems). I fixed a few small bugs there, but it's been left mostly untouched/unfixed.

The VDKQueue docs say it is 10.7+ only due to the use of @autoreleasepools - we know these build for @HenningJ on 10.6, but it would be helpful if @HenningJ could test this build before we merge - just to make sure 10.6 is safe.

[skurfer]

Apparently, I need to learn about submodules before I can test this. :-)

[skurfer]

OK, I tested and this seems to work from what I can tell. (I added and removed files in a “voyeured” directory and the changes were reflected immediately.)

The submodule business makes it a bit of a pain to switch between branches, though. Is it worth it for two files?

[pjrobertson]

The submodule business makes it a bit of a pain to switch between
branches, though. Is it worth it for two files?

Once it's merged in and all your branches have it, it shouldn't be a
problem. We can always add the 'VDKQueue' to the .gitignore.

The upside is that we pull all the latest code changes for VDKQueue
directly into QS, so we're always up to date :)

On 18 June 2012 16:24, Rob McBroom <
reply@reply.github.com

wrote:

OK, I tested and this seems to work from what I can tell. (I added and
removed files in a “voyeured” directory and the changes were reflected
immediately.)

The submodule business makes it a bit of a pain to switch between
branches, though. Is it worth it for two files?

---

Reply to this email directly or view it on GitHub:
#944 (comment)

[skurfer]

Once it's merged in and all your branches have it, it shouldn't be a problem.

Another thing I was going to mention is that we’d have to update the documentation on building from source. It’ll no longer be enough to clone the repo and build. People will need to set up the modules, too. If we’re going to be using more and more modules (which I’m guessing we are), then it’s no extra work, but something we need to think about.

The upside is that we pull all the latest code changes for VDKQueue directly into QS, so we're always up to date :)

Only if you update the commit that it refers to. So we have to manage one file instead of two. :-) But again, if we’re going to use modules more and more, it’s probably worth it.

So I’m guessing those two half-hearted points aren’t going to change your mind.

[HenningJ]

I just tried it and it built fine for me.

(Well, apart from the NSURLConnectionDelegate protocol in QSCrashReporterWindowController.h, which doesn't exist on 10.6, but once you remove it, it works fine.)

Btw. I agree that git submodules are the correct way to do this, even though they are a little weird to work with.

[pjrobertson]

So any further problems with this? We know it works on 10.6 which is the main thing

[skurfer]

No, I was just waiting for an answer to @HenningJ’s concerns. I didn’t get a notification since it was a comment on a commit. Merging.

Be sure to update the wiki for first-time builders.