Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean up problems found by the analyzer #950

Merged
merged 5 commits into from Jun 25, 2012
Merged

clean up problems found by the analyzer #950

merged 5 commits into from Jun 25, 2012

Conversation

skurfer
Copy link
Member

@skurfer skurfer commented Jun 20, 2012

I attempted to fix everything it found, except for things in the ND* classes and a couple of things where @fheckl left comments explaining why they were OK as is.

@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 20, 2012

A few things here and there that should probably be looked into, but other
than that it seems fine.

I've seen in the past that the staid analyser can give lots of false
positives so it's worth checking over the changes you've made two, maybe
three times to make sure they make sense.

On 20 June 2012 04:36, Rob McBroom <
reply@reply.github.com

wrote:

I attempted to fix everything it found, except for things in the ND*
classes and a couple of things where @fheckl left comments explaining why
they were OK as is.

You can merge this Pull Request by running:

git pull https://github.com/skurfer/Quicksilver analyzer

Or you can view, comment on it, or merge it online at:

#950

-- Commit Summary --

  • clean up problems found by the analyzer

-- File Changes --

M Quicksilver/Code-App/QSAboutWindowController.m (1)
M Quicksilver/Code-App/QSCatalogPrefPane.m (2)
M Quicksilver/Code-App/QSController.m (5)
M Quicksilver/Code-App/QSUpdateController.m (5)
M Quicksilver/Code-QuickStepCore/QSAction.m (2)
M Quicksilver/Code-QuickStepCore/QSBasicObject.h (2)
M Quicksilver/Code-QuickStepCore/QSBasicObject.m (2)
M Quicksilver/Code-QuickStepCore/QSCatalogEntry.m (2)
M Quicksilver/Code-QuickStepCore/QSCommand.m (2)
M Quicksilver/Code-QuickStepCore/QSCrashReporterWindowController.m (5)
M Quicksilver/Code-QuickStepCore/QSObject.m (4)
M Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m (1)
M Quicksilver/Code-QuickStepCore/QSObject_URLHandling.m (2)
M Quicksilver/Code-QuickStepCore/QSTriggerCenter.m (4)
M Quicksilver/Code-QuickStepFoundation/NSMetadataQuery+Synchronous.m (2)
M Quicksilver/Code-QuickStepFoundation/NSString_BLTRExtensions.m (4)
M
Quicksilver/PlugIns-Main/QSCorePlugIn/Code/QSActionProvider_EmbeddedProviders.m
(7)

-- Patch Links --

https://github.com/quicksilver/Quicksilver/pull/950.patch
https://github.com/quicksilver/Quicksilver/pull/950.diff


Reply to this email directly or view it on GitHub:
#950

skurfer added 4 commits Jun 20, 2012
But unlike the previous commit for this, leave it around and set it to
`nil` when necessary to influence the window behavior.
@pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 25, 2012

Looks good, merged

pjrobertson added a commit that referenced this issue Jun 25, 2012
clean up problems found by the analyzer
@pjrobertson pjrobertson merged commit 64794a0 into quicksilver:release Jun 25, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants