clean up problems found by the analyzer

[skurfer]

I attempted to fix everything it found, except for things in the ND* classes and a couple of things where @fheckl left comments explaining why they were OK as is.

[pjrobertson]

A few things here and there that should probably be looked into, but other
than that it seems fine.

I've seen in the past that the staid analyser can give lots of false
positives so it's worth checking over the changes you've made two, maybe
three times to make sure they make sense.

On 20 June 2012 04:36, Rob McBroom <
reply@reply.github.com

wrote:

I attempted to fix everything it found, except for things in the ND*
classes and a couple of things where @fheckl left comments explaining why
they were OK as is.

You can merge this Pull Request by running:

git pull https://github.com/skurfer/Quicksilver analyzer

Or you can view, comment on it, or merge it online at:

#950

-- Commit Summary --

• clean up problems found by the analyzer

-- File Changes --

M Quicksilver/Code-App/QSAboutWindowController.m (1)
M Quicksilver/Code-App/QSCatalogPrefPane.m (2)
M Quicksilver/Code-App/QSController.m (5)
M Quicksilver/Code-App/QSUpdateController.m (5)
M Quicksilver/Code-QuickStepCore/QSAction.m (2)
M Quicksilver/Code-QuickStepCore/QSBasicObject.h (2)
M Quicksilver/Code-QuickStepCore/QSBasicObject.m (2)
M Quicksilver/Code-QuickStepCore/QSCatalogEntry.m (2)
M Quicksilver/Code-QuickStepCore/QSCommand.m (2)
M Quicksilver/Code-QuickStepCore/QSCrashReporterWindowController.m (5)
M Quicksilver/Code-QuickStepCore/QSObject.m (4)
M Quicksilver/Code-QuickStepCore/QSObject_FileHandling.m (1)
M Quicksilver/Code-QuickStepCore/QSObject_URLHandling.m (2)
M Quicksilver/Code-QuickStepCore/QSTriggerCenter.m (4)
M Quicksilver/Code-QuickStepFoundation/NSMetadataQuery+Synchronous.m (2)
M Quicksilver/Code-QuickStepFoundation/NSString_BLTRExtensions.m (4)
M
Quicksilver/PlugIns-Main/QSCorePlugIn/Code/QSActionProvider_EmbeddedProviders.m
(7)

-- Patch Links --

https://github.com/quicksilver/Quicksilver/pull/950.patch
https://github.com/quicksilver/Quicksilver/pull/950.diff

---

Reply to this email directly or view it on GitHub:
#950

[pjrobertson]

Looks good, merged