remove redundant xcconfig files #956

Merged
merged 1 commit into from Aug 13, 2012

Conversation

Projects
None yet
3 participants
Owner

skurfer commented Jun 25, 2012

Just for simplification. I’ve already discussed this with @pjrobertson on IRC.

The removed files just combine Debug/Release with QSPlugIn. Since the Debug/Release configs are already included at the project level, all the targets really need is the QSPlugIn config.

There are several plug-ins referring to the QSPlugIn_Debug and QSPlugIn_Release files, but the surest way to see that we fix that is to not give us a choice. :-)

If these files are necessary for reasons I’m not aware of, let me know.

Owner

pjrobertson commented Jun 25, 2012

Yeah, the only issue I expressed with this was for 3rd party devs (or us when we forget). It'll cause a huge headache trying to figure out what's wrong I guess, but I've just tested it and strangely, plugins seems to build even once the files have been deleted :/

Thoughts?

Owner

skurfer commented Jun 26, 2012

It would probably be good to have input from @tiennou as I think he set all this up originally.

Owner

tiennou commented Jul 4, 2012

If these files are necessary for reasons I’m not aware of, let me know.

Separation of concerns mainly ;-). The whole point of the xcconfig files was to workaround Xcode 3's inability to have settings defined in a "master" project (the Quicksilver one) and have them available in subprojects (the plugins), for things like copying the built plugins inside the Quicksilver bundle (combined with the /tmp/QS hack). I think all this mess could be dropped with a thorough review of Xcode 4's workspace ability (and the fact that it now puts it's build product mess inside the user's dir, akin to what I did with the /tmp/QS stuff).

skurfer referenced this pull request in jordanekay/OpenMetaFileTagging Jul 23, 2012

Closed

Initial comments #1

@pjrobertson pjrobertson added a commit that referenced this pull request Aug 13, 2012

@pjrobertson pjrobertson Merge pull request #956 from skurfer/xcconfig
remove redundant xcconfig files
33c28ec

@pjrobertson pjrobertson merged commit 33c28ec into quicksilver:master Aug 13, 2012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment