Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When there's no internet connection, return the original items for web sources, fixes #634 #960

Merged
merged 1 commit into from Jul 23, 2012

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jun 26, 2012

Unfortunately, as suggested by @skurfer in #634, altering the indexIsValidFromDate:forEntry method won't work because it is already set to return YES always.

The solution is to check for an error when retrieving internet contents - if there is one, then return the original catalog entry items.
This doesn't affect the behaviour if a web source is valid, but returns no results. In that case an empty array ([NSArray array]) is returned, and the catalog entry is actually set to have 0 contents.

@skurfer
Copy link
Member

@skurfer skurfer commented Jul 23, 2012

Refreshing one of these entries with no connection doesn’t clear the contents. Sounds like that’s what we’re after. Merging.

skurfer added a commit that referenced this issue Jul 23, 2012
When there's no internet connection, return the original items for web sources, fixes #634
@skurfer skurfer merged commit 953723f into quicksilver:master Jul 23, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants