Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip to third pane, fixes #966 #982

Merged
merged 6 commits into from Aug 21, 2012
Merged

Conversation

pjrobertson
Copy link
Member

@pjrobertson pjrobertson commented Jul 8, 2012

When an action requires an iObject, ⌘⇧Letter shortcuts show the 3rd pane instead of trying to execute the action and failing.

There are also a few optimisations along the way. One such (see the line comment) appears to be small, but in fact reduces the number of calls to various methods quite a bit. Probably worth running with this pull for a while to make sure there are no funny things going on.

@iaj
Copy link

@iaj iaj commented Jul 9, 2012

Mh, I was just trying this one out.. And I had the following problem:

Once I narrowed down my search, eg. into a certain folder.. then hit escape...
and bring QS back up, I cant search the global catalog anymore - just the narrowed
down search.

Is that to be expected? Have to restart QS to have the whole catalog back again =)

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Jul 9, 2012

@iaj - probably a bug from my over-optimisation. I was worried this might be the case. I'll look into it, thanks

@pjrobertson
Copy link
Member Author

@pjrobertson pjrobertson commented Aug 12, 2012

@iaj - I can't reproduce what you're saying. That was an issue with certain interfaces a while back.

This still seems fine for me.
Ready for texting/pulling if you ask me :)

Conflicts:
	Quicksilver/Code-QuickStepInterface/QSInterfaceController.m
@skurfer
Copy link
Member

@skurfer skurfer commented Aug 21, 2012

Been running this for a while. Works as described and I haven't encountered any problems.

skurfer added a commit that referenced this issue Aug 21, 2012
@skurfer skurfer merged commit 3f4a7e9 into quicksilver:master Aug 21, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants