New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More sound similar class detector #7

Closed
schani opened this Issue Jul 18, 2017 · 1 comment

Comments

Projects
None yet
1 participant
@schani
Collaborator

schani commented Jul 18, 2017

Right now we pick one class and then find all classes that are similar to it. But depending on which class you start out with, you can end up with different sets. So we might want to find sets where all classes are pairwise similar. The complexity of that is most likely larger, definitely when implemented naively.

@schani

This comment has been minimized.

Collaborator

schani commented Nov 23, 2017

This is a highly nontrivial problem - it's about finding cliques in graphs. Our new class combiner builds cliques eagerly, which means the classes we combine are always pairwise similar, i.e. it's an improvement over the old algorithm. Depending on the order of the classes we might still find different cliques, however. The ideal would be to start with the largest clique, but finding that takes exponential time, so no.

@schani schani closed this Nov 23, 2017

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment