Fix GC actor integration #584
Conversation
evanxg852000
force-pushed
the
fix-573
branch
2 times, most recently
from
8fdcb41
to
d2bfc4e
Compare
| if handlers.publisher.health() != Health::Healthy | ||
| && handlers.garbage_collector.health() == Health::Healthy |
There was a problem hiding this comment.
There was a bug in the indexer logic.
Let me try to describe the problem it is a bit tricky.
.health() is actually mutating something.
It uses a strange contraption in the Progress object that checks if a has_changed is set to true.
At every healthchec this flag is checked, and the actor is in charge of flipping it up until the next iteration of the loop.
Here we call health a second time right after the regular healthcheck call. 95% of the time the actor will not have modified it so that both the publisher and the garbage collector are not healthy.
The fix I added for the MergePlanner is checking for the state of the actors instead.
There was a problem hiding this comment.
This is why I was:
I resorted to the finalize method of the publisher. checking the health state of the publisher from the supervisor was yielding inconsistent state.
Description
Closes #573
Fixed GC Actor integration into pipeline
How was this PR tested?
Run indexing