Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OnRetransmissionTimeoutVerified issue #1774

Closed
larseggert opened this issue Sep 19, 2018 · 1 comment
Closed

OnRetransmissionTimeoutVerified issue #1774

larseggert opened this issue Sep 19, 2018 · 1 comment
Assignees
@ianswett
Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@larseggert
Copy link
Member

Issue for what I described to @ianswett at dinner yesterday.

When OnRetransmissionTimeoutVerified is called from OnPacketAcked for the highest ACK in a block, all earlier packets are marked as lost, even if they are contained in that same block. That seems suboptimal.
@larseggert larseggert changed the title OnPacketAcked issue OnRetransmissionTimeoutVerified issue Sep 19, 2018
@ianswett ianswett added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Sep 19, 2018
@ianswett
Copy link
Contributor

Yeah, this is not intended behavior, so I'll clarify that both the text and pseudocode.

ianswett added a commit that referenced this issue Oct 2, 2018
@ianswett
Track smallest_newly_acked to prevent spurious RTO
b703cfd 
Fixes #1774
@ianswett ianswett mentioned this issue Oct 2, 2018
Merged
janaiyengar pushed a commit that referenced this issue Oct 3, 2018
@ianswett @janaiyengar
Track smallest_newly_acked to prevent spurious RTO (#1822)
b98e75a 
* Track smallest_newly_acked to prevent spurious RTO

Fixes #1774

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* Update draft-ietf-quic-recovery.md

* acket
@ianswett ianswett mentioned this issue Nov 5, 2018
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ianswett ianswett

Labels
-recovery editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@larseggert @ianswett