Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Confusing text around push streams #2225

Closed
ekr opened this issue Dec 20, 2018 · 4 comments
Closed

Confusing text around push streams #2225

ekr opened this issue Dec 20, 2018 · 4 comments
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.

Comments

@ekr
Copy link
Collaborator

ekr commented Dec 20, 2018

S 3.2.2.

A push stream is indicated by a stream type of `0x50` (ASCII 'P'), followed by
the Push ID of the promise that it fulfills, encoded as a variable-length
integer. The remaining data on this stream consists of HTTP/3 frames, as defined
in {{frames}}, and fulfills a promised server push.  Server push and Push IDs
are described in {{server-push}}.

This isn't understandable without knowing what push is or what a PUSH
promise is. Am I supposed to get that from 7540? In either case, you
should clearly state that a push stream can only be used for a single
push promise (this is implied by the formatting). Happy to supply a PR if
we can agree on what's wanted?

@martinthomson martinthomson added the editorial An issue that does not affect the design of the protocol; does not require consensus. label Dec 21, 2018
@martinthomson
Copy link
Member

Yes, as currently written, a push stream corresponds 1:1 with a PUSH_PROMISE. Which is consistent again with 7540 (we had a period where it was not).

@LPardue
Copy link
Member

LPardue commented Dec 21, 2018

Well. A push stream corresponds one-to-one with a push ID. You can duplicate promises using the DUPLICATE_PUSH frame.

I think this is what was attempted to be described by the term "promised server push" as abstract from the frames that might get sent. If the language needs to improve to make this clearer then lets do it.

@MikeBishop MikeBishop added this to Push in HTTP / QPACK Jan 17, 2019
@MikeBishop MikeBishop removed this from Push in HTTP / QPACK Jan 31, 2019
@MikeBishop
Copy link
Contributor

Does #2701 address this sufficiently, now that the description of push precedes this section? There's already a back-reference at the end of the paragraph if someone needs more details.

@MikeBishop
Copy link
Contributor

Closing; please reopen if you feel that #2701 does not sufficiently address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http editorial An issue that does not affect the design of the protocol; does not require consensus.
Projects
None yet
Development

No branches or pull requests

5 participants