Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ACK/STOP_WAITING into the packet header #70

Closed
MikeBishop opened this issue Dec 5, 2016 · 3 comments
Closed

Move ACK/STOP_WAITING into the packet header #70

MikeBishop opened this issue Dec 5, 2016 · 3 comments
Labels
-transport design has-consensus

Comments

@MikeBishop
Copy link
Contributor

@MikeBishop MikeBishop commented Dec 5, 2016

Mirja Kühlewind points out that multiple ACK frames per packet don't really make sense, and they aren't retransmittable. Instead, Mirja suggests replacing the ACK frame with an optional region in the packet header and a bit indicating its presence. STOP_WAITING, already a candidate for removal (#66), could be consolidated here as well.

@MikeBishop MikeBishop added design -transport labels Dec 5, 2016
@ianswett
Copy link
Contributor

@ianswett ianswett commented Dec 5, 2016

Could you clarify what you mean by packet header? There is currently no encrypted packet header, so we'd have to create one in order to place the ack frame there. I'll point out two connection close frames in a packet make even less sense. Or PING frames.

@MikeBishop
Copy link
Contributor Author

@MikeBishop MikeBishop commented Dec 5, 2016

And I think that's the distinction. If we had an encrypted header region, it could logically hold a lot of the connection-level information. Of course, if we allow that set of stuff to be extensible, it could wind up looking a lot like frames. ;-) Updating the title to better reflect the suggestion.

@janaiyengar janaiyengar added the needs-discussion label Jan 14, 2017
@mnot mnot changed the title Consider moving ACK/STOP_WAITING into the packet header Move ACK/STOP_WAITING into the packet header Jan 20, 2017
@mnot
Copy link
Member

@mnot mnot commented Jan 26, 2017

As discussed in Tokyo, dropped (for now)

@mnot mnot closed this Jan 26, 2017
@mnot mnot added notify-consensus and removed needs-discussion labels Jan 26, 2017
@mnot mnot added the has-consensus label Apr 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-transport design has-consensus
Projects
None yet
Development

No branches or pull requests

4 participants