Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Flags #1398

Merged
merged 2 commits into from Jun 6, 2018
Merged

Remove Flags #1398

merged 2 commits into from Jun 6, 2018

Conversation

MikeBishop
Copy link
Contributor

Fixes #1388.

@MikeBishop MikeBishop added design An issue that affects the design of the protocol; resolution requires consensus. -http labels May 29, 2018
Copy link
Member

@martinthomson martinthomson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep, this is good. I didn't check that you hit every frame type properly, but it looks like you did.

@@ -614,6 +595,20 @@ The flags defined are:

The PRIORITY frame payload has the following fields:

Flags:
: An eight-bit field containing flags. The flags defined are:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should explicitly say that other flags must be zero on sending and either must be ignored on receipt or must be error if non-zero.

@MikeBishop MikeBishop merged commit 35e7e7f into master Jun 6, 2018
@MikeBishop MikeBishop deleted the strike_the_colors branch June 14, 2018 23:37
igorlord pushed a commit to igorlord/quic-base-drafts that referenced this pull request Jun 18, 2018
* Remove Flags

* Zero on send, ignored on receipt
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
-http design An issue that affects the design of the protocol; resolution requires consensus.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants