Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use max_ack_delay = 0 before receving the TPs #2646

Merged
merged 5 commits into from May 7, 2019
Merged

use max_ack_delay = 0 before receving the TPs #2646

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
470eed0
use max_ack_delay = 0 before receving the TPs
marten-seemann Apr 24, 2019
62d0a55
don't use max_ack_delay for Initial and Handshake packets
marten-seemann Apr 28, 2019
3779c9c
don't use a default ack_delay_exponent for Initial and Handshake packets
marten-seemann Apr 29, 2019
680e20f
it's called ApplicationData packet number space, not 1-RTT
ianswett Apr 30, 2019
b466b28
max_ack_delay applies to ApplicationData pn space, not on 1-RTT packets
marten-seemann Apr 30, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
13 changes: 6 additions & 7 deletions draft-ietf-quic-transport.md
View file
Open in desktop
Expand Up @@ -4173,9 +4173,8 @@ ack_delay_exponent (0x000a):

: The ACK delay exponent is an integer value indicating an
exponent used to decode the ACK Delay field in the ACK frame ({{frame-ack}}).
If this value is absent, a default value of 3 is assumed
(indicating a multiplier of 8). The default value is also used for ACK frames
that are sent in Initial and Handshake packets. Values above 20 are invalid.
If this value is absent, a default value of 3 is assumed (indicating a
multiplier of 8). Values above 20 are invalid.

max_ack_delay (0x000b):

Expand Down Expand Up @@ -4330,10 +4329,10 @@ ACK Delay:
in the Largest Acknowledged field, was received by this peer. The value of
the ACK Delay field is scaled by multiplying the encoded value by 2 to the
power of the value of the `ack_delay_exponent` transport parameter set by the
sender of the ACK frame. The `ack_delay_exponent` defaults to 3, or a
multiplier of 8 (see {{transport-parameter-definitions}}). Scaling in this
fashion allows for a larger range of values with a shorter encoding at the
cost of lower resolution.
sender of the ACK frame (see {{transport-parameter-definitions}}). Scaling in
this fashion allows for a larger range of values with a shorter encoding at
the cost of lower resolution. Because the receiver doesn't use the ACK Delay
for Initial and Handshake packets, a sender SHOULD send a value of 0.

ACK Range Count:

Expand Down